chore: Adjust orchestration tests (#84)

Author: KavithaSiva

packages/gen-ai-hub/src/orchestration/orchestration-client.test.ts

@@ -72,7 +72,10 @@ describe('GenAiHubClient', () => {
       },
       prompt: {
         template: [
-          { role: 'user', content: 'Create {number} paraphrases of {phrase}' }
+          {
+            role: 'user',
+            content: 'Create {{?number}} paraphrases of {{?phrase}}'
+          }
         ],
         template_params: { phrase: 'I hate you.', number: 3 }
       },
@@ -114,7 +117,10 @@ describe('GenAiHubClient', () => {
       },
       prompt: {
         template: [
-          { role: 'user', content: 'Create {number} paraphrases of {phrase}' }
+          {
+            role: 'user',
+            content: 'Create {{?number}} paraphrases of {{?phrase}}'
+          }
         ],
         template_params: { phrase: 'I hate you.', number: 3 }
       },

packages/gen-ai-hub/src/orchestration/orchestration-completion-post-request.test.ts

@@ -46,10 +46,34 @@ describe('constructCompletionPostRequest()', () => {
     expect(completionPostRequest).toEqual(expectedCompletionPostRequest);
   });
 
+  // Todo: Adapt the test after Cloud SDK fix for: https://github.com/SAP/cloud-sdk-backlog/issues/1234
+  it('with model configuration and empty template', async () => {
+    genaihubCompletionParameters.prompt.template = [];
+    const expectedCompletionPostRequest: CompletionPostRequest = {
+      orchestration_config: {
+        module_configurations: {
+          templating_module_config: {
+            template: []
+          },
+          llm_module_config: {
+            model_name: 'gpt-35-turbo-16k',
+            model_params: { max_tokens: 50, temperature: 0.1 }
+          }
+        }
+      }
+    };
+    const completionPostRequest: CompletionPostRequest =
+      constructCompletionPostRequest(genaihubCompletionParameters);
+    expect(completionPostRequest).toEqual(expectedCompletionPostRequest);
+  });
+
   it('with model configuration, prompt template and template params', async () => {
     genaihubCompletionParameters.prompt = {
       template: [
-        { role: 'user', content: 'Create {number} paraphrases of {phrase}' }
+        {
+          role: 'user',
+          content: 'Create {{?number}} paraphrases of {{?phrase}}'
+        }
       ],
       template_params: { phrase: 'I hate you.', number: 3 }
     };
@@ -60,7 +84,7 @@ describe('constructCompletionPostRequest()', () => {
             template: [
               {
                 role: 'user',
-                content: 'Create {number} paraphrases of {phrase}'
+                content: 'Create {{?number}} paraphrases of {{?phrase}}'
               }
             ]
           },
@@ -77,6 +101,40 @@ describe('constructCompletionPostRequest()', () => {
     expect(completionPostRequest).toEqual(expectedCompletionPostRequest);
   });
 
+  it('with model configuration, prompt template and empty template params', async () => {
+    genaihubCompletionParameters.prompt = {
+      template: [
+        {
+          role: 'user',
+          content: 'Create {{?number}} paraphrases of {{?phrase}}'
+        }
+      ],
+      template_params: {}
+    };
+    const expectedCompletionPostRequest: CompletionPostRequest = {
+      orchestration_config: {
+        module_configurations: {
+          templating_module_config: {
+            template: [
+              {
+                role: 'user',
+                content: 'Create {{?number}} paraphrases of {{?phrase}}'
+              }
+            ]
+          },
+          llm_module_config: {
+            model_name: 'gpt-35-turbo-16k',
+            model_params: { max_tokens: 50, temperature: 0.1 }
+          }
+        }
+      },
+      input_params: {}
+    };
+    const completionPostRequest: CompletionPostRequest =
+      constructCompletionPostRequest(genaihubCompletionParameters);
+    expect(completionPostRequest).toEqual(expectedCompletionPostRequest);
+  });
+
   it('with model name, empty model parameters and prompt template', async () => {
     genaihubCompletionParameters.llmConfig = {
       model_name: 'gpt-35-turbo-16k',
@@ -205,6 +263,7 @@ describe('constructCompletionPostRequest()', () => {
     expect(completionPostRequest).toEqual(expectedCompletionPostRequest);
   });
 
+  // Todo: Adapt the test after Cloud SDK fix for: https://github.com/SAP/cloud-sdk-backlog/issues/1234
   it('with model configuration, prompt template empty filter configuration', async () => {
     genaihubCompletionParameters.filterConfig = {};
     const expectedCompletionPostRequest: CompletionPostRequest = {

tests/e2e-tests/src/orchestration.test.ts

@@ -20,12 +20,27 @@ describe('orchestration', () => {
         model_params: { max_tokens: 50, temperature: 0.1 }
       },
       prompt: {
-        template: [{ role: 'user', content: 'Hello!' }]
+        template: [
+          {
+            role: 'user',
+            content:
+              'Create {{?number}} paraphrases of {{?phrase1}} and {{?phrase2}}'
+          }
+        ],
+        template_params: {
+          number: '3',
+          phrase1: 'I love coffee',
+          phrase2: 'I dislike cats'
+        }
       }
     };
     const response = await new GenAiHubClient().chatCompletion(request);
 
     expect(response.module_results).toBeDefined();
+    expect(response.module_results.templating).not.toHaveLength(0);
+    expect(response.module_results.templating?.[0].content).toBe(
+      'Create 3 paraphrases of I love coffee and I dislike cats'
+    );
     expect(response.orchestration_result.choices).not.toHaveLength(0);
   });
 });