Skip to content

Commit ae92853

Browse files
committed
[INTERNAL] Azure: Disable AVA worker threads
This is to workaround for the "FATAL ERROR: v8::FromJust Maybe value is Nothing." errors we see for our Windows and macOS test executions on Azure. The error is sporadic, but most consistently appears on Windows 2022 (Azure image '20230630.1.0' and Node v18.16.1. avajs/ava#2947 seems to suggest this is a Node.js issue as reported at nodejs/node#43304 Disabling the use of our own worker threads in minifier.js resolve the issue. Disabling worker threads in AVA resolves it too. Since we want to test our worker threads, we opted for the latter by setting the AVA option '--no-worker-threads' for all scripts executed in Azure. All this indicates an issue with using worker threads (or the workerpool package) from within workers.
1 parent fd542df commit ae92853

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

azure-pipelines.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,6 @@ steps:
6969
codeCoverageTool: 'cobertura'
7070
summaryFileLocation: '$(System.DefaultWorkingDirectory)/coverage/cobertura-coverage.xml'
7171

72-
- script: npm run coverage
72+
- script: npm run coverage -- --no-worker-threads
7373
displayName: Run Test Natively in Case of Failures
7474
condition: failed()

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"unit": "rimraf test/tmp && ava",
3939
"unit-verbose": "rimraf test/tmp && cross-env UI5_LOG_LVL=verbose ava --verbose --serial",
4040
"unit-watch": "rimraf test/tmp && ava --watch",
41-
"unit-xunit": "rimraf test/tmp && ava --node-arguments=\"--experimental-loader=@istanbuljs/esm-loader-hook\" --tap --timeout=1m | tap-xunit --dontUseCommentsAsTestNames=true > test-results.xml",
41+
"unit-xunit": "rimraf test/tmp && ava --no-worker-threads --node-arguments=\"--experimental-loader=@istanbuljs/esm-loader-hook\" --tap --timeout=1m | tap-xunit --dontUseCommentsAsTestNames=true > test-results.xml",
4242
"unit-inspect": "cross-env UI5_LOG_LVL=verbose ava debug --break",
4343
"coverage": "rimraf test/tmp && nyc ava --node-arguments=\"--experimental-loader=@istanbuljs/esm-loader-hook\"",
4444
"coverage-xunit": "nyc --reporter=text --reporter=text-summary --reporter=cobertura npm run unit-xunit",

0 commit comments

Comments
 (0)