fix: wrong cc and readme file (#623)

* fix: no cc for wrong position

* fix: update readme file

* fix: change set

---------

Co-authored-by: vadson71 <[email protected]>

Author: marufrasully

.changeset/sour-pandas-behave.md

@@ -0,0 +1,7 @@
+---
+"@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext": patch
+"vscode-ui5-language-assistant": patch
+"@ui5-language-assistant/binding": patch
+---
+
+No code completion for wrong position

packages/binding/src/services/completion/providers/property-binding-info.ts

@@ -1,7 +1,7 @@
 import {
   parseBinding,
   BindingParserTypes as BindingTypes,
-  positionContained,
+  rangeContained,
 } from "@ui5-language-assistant/binding-parser";
 import type { Position } from "vscode-languageserver-types";
 import { AttributeValueCompletionOptions } from "@xml-tools/content-assist";
@@ -90,7 +90,10 @@ export function propertyBindingInfoSuggestions({
     }
     const cursorPos = context.textDocumentPosition?.position;
     const binding = ast.bindings.find(
-      (b) => cursorPos && positionContained(b.range, cursorPos)
+      (b) =>
+        cursorPos &&
+        b.range &&
+        rangeContained(b.range, { start: cursorPos, end: cursorPos })
     );
     if (!binding) {
       continue;

packages/binding/test/unit/services/completion/index.test.ts

@@ -141,6 +141,14 @@ describe("index", () => {
         result.map((item) => completionItemToSnapshot(item, true))
       ).toStrictEqual([]);
     });
+    it("provides no CC on wrong position", async function () {
+      const snippet = `
+        <Input maxLength="${CURSOR_ANCHOR}{path: ''}"/>`;
+      const result = await getCompletionResult(snippet);
+      expect(
+        result.map((item) => completionItemToSnapshot(item, true))
+      ).toStrictEqual([]);
+    });
     it("provides no CC for metadata binding", async function () {
       const snippet = `
         <Input maxLength="{/#Company${CURSOR_ANCHOR}/ZipCode/@maxLength}"/>`;

packages/vscode-ui5-language-assistant/README.md

@@ -50,6 +50,7 @@ The feature is available in the following:
   - metaPath values in building blocks
   - contextPath values for Chart building blocks
   - filterBar values from the current file in building blocks
+  - property binding info when possible
 
 ### XML View Validations
 
@@ -73,6 +74,14 @@ and cannot be configured by the end user.
   - Wrong cardinality of aggregation
   - Wrong type of tags inside aggregations
   - Missing or empty ID when `flexEnabled` is true (stableID)
+  - property binding info
+    - missing key
+    - missing or extra colon(s)
+    - missing or wrong value
+    - missing or extra comma(s)
+    - duplicate keys
+    - unknown key or char(s)
+    - recursive composite bindings
 
 - Warnings: