Skip to content

Commit 0bbfb2c

Browse files
authored
fix: readme content correction (#609)
* fix: readme content correction * fix: bug fix * fix: cleanup
1 parent f6445d0 commit 0bbfb2c

File tree

3 files changed

+11
-15
lines changed

3 files changed

+11
-15
lines changed

.changeset/shaggy-houses-scream.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"vscode-ui5-language-assistant": patch
3+
"@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext": patch
4+
---
5+
6+
Fixed incorrect update of README file in repo root

README.md

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,6 @@ It currently contains:
3535
[npm-bas-ext-url]: https://www.npmjs.com/package/@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext
3636
[npm-bas-ext-image]: https://img.shields.io/npm/v/@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext.svg
3737

38-
## Limitations
39-
40-
### UI5 version and framework.
41-
42-
This extension derives the UI5 version in the following sequence:
43-
44-
1. The `minUI5Version` from the manifest.json file (see note)
45-
2. Lookup in CDN for UI5 version and negotiate to the closest LTS version (see note).
46-
3. If it is not found or the version is 1.38 or older, then default back to 1.71 (latest patch level). The framework (SAPUI5/OpenUI5) is derived from the ui5.yaml file. This defaults to SAPUI5.
47-
48-
Note: If `minUI5Version` not found in the manifest.json or lookup in CDN fails, then fall back to default 1.71.49 version
49-
5038
## Support
5139

5240
Please open [issues](https://github.com/SAP/ui5-language-assistant/issues) on github.

packages/vscode-ui5-language-assistant/README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,9 +179,11 @@ When configuring local web server, make sure it responds to the exact UI5 versio
179179

180180
This extension derives the UI5 version in the following sequence:
181181

182-
1. the minUI5Version from the manifest.json file
183-
2. Lookup in CDN for UI5 version and negotiates to the closest LTS version, if not found
184-
3. Default back to 1.71 (latest patch level)
182+
1. The `minUI5Version` from the manifest.json file (see note)
183+
2. Lookup in CDN for UI5 version and negotiate to the closest LTS version (see note).
184+
3. If it is not found or the version is 1.38 or older, then default back to 1.71 (latest patch level).
185+
186+
Note: If `minUI5Version` not found in the manifest.json or lookup in CDN fails, then fall back to default 1.71.49 version
185187

186188
The framework(SAPUI5/OpenUI5) is derived from the ui5.yaml file. This defaults to SAPUI5.
187189

0 commit comments

Comments
 (0)