Skip to content

Commit 898c3b6

Browse files
authored
fix: correct text (#736)
* fix: correct text * fix: add change set * fix: default ui5 version * fix: failing tests
1 parent cb055b0 commit 898c3b6

File tree

7 files changed

+18
-12
lines changed

7 files changed

+18
-12
lines changed

.changeset/light-books-kiss.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"vscode-ui5-language-assistant": patch
3+
"@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext": patch
4+
---
5+
6+
fix: correct SAPUI5 term

examples/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ This folder contains a collection of examples
44

55
## sap-ui5-web-server
66

7-
A local web server to host SAP UI5 SDK
7+
A local web server to host SAPUI5 SDK

packages/constant/src/constant.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ export const OPEN_FRAMEWORK = "OpenUI5";
22
export const DEFAULT_UI5_FRAMEWORK = "SAPUI5";
33

44
//https://ui5.sap.com/version.json
5-
export const DEFAULT_UI5_VERSION = "1.71.70";
5+
export const DEFAULT_UI5_VERSION = "1.71.72";
66
// https://sdk.openui5.org/version.json
7-
export const DEFAULT_OPEN_UI5_VERSION = "1.71.67";
7+
export const DEFAULT_OPEN_UI5_VERSION = "1.71.68";
88

99
export const DEFAULT_UI5_VERSION_BASE = "1.71";
1010

packages/logic-utils/test/unit/ui5.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ describe("getVersionInfoUrl", () => {
7272
DEFAULT_UI5_VERSION
7373
);
7474
expect(result).toStrictEqual(
75-
"https://ui5.sap.com/1.71.70/resources/sap-ui-version.json"
75+
"https://ui5.sap.com/1.71.72/resources/sap-ui-version.json"
7676
);
7777
});
7878
it("get version info uri for OpenUI5", async () => {
@@ -81,7 +81,7 @@ describe("getVersionInfoUrl", () => {
8181
DEFAULT_OPEN_UI5_VERSION
8282
);
8383
expect(result).toStrictEqual(
84-
"https://sdk.openui5.org/1.71.67/resources/sap-ui-version.json"
84+
"https://sdk.openui5.org/1.71.68/resources/sap-ui-version.json"
8585
);
8686
});
8787
});
@@ -93,7 +93,7 @@ it("getLibraryAPIJsonUrl", async () => {
9393
"sap.m"
9494
);
9595
expect(result).toStrictEqual(
96-
"https://ui5.sap.com/1.71.70/test-resources/sap/m/designtime/api.json"
96+
"https://ui5.sap.com/1.71.72/test-resources/sap/m/designtime/api.json"
9797
);
9898
});
9999

@@ -117,7 +117,7 @@ describe("getVersionsMap", () => {
117117
it("get version map for OpenUI5 - fallback default", async () => {
118118
const data = {
119119
latest: {
120-
version: "1.71.67",
120+
version: "1.71.68",
121121
support: "Maintenance",
122122
lts: true,
123123
},

packages/vscode-ui5-language-assistant/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ When working with CAP projects, make sure you have @sap/cds module installed. Fo
210210

211211
### Enabling offline work
212212

213-
You can set up a local web server to host one or more supported versions of SAP UI5 SDK and register it in the user/workspace setting `"UI5LanguageAssistant.SAPUI5WebServer"`. This overrides the public CDN of SAP UI5 SDK in the extension and enables offline work with the apps having the matching hosted `"minUI5Version"` in `manifest.json`.
213+
You can set up a local web server to host one or more supported versions of SAPUI5 SDK and register it in the user/workspace setting `"UI5LanguageAssistant.SAPUI5WebServer"`. This overrides the public CDN of SAPUI5 SDK in the extension and enables offline work with the apps having the matching hosted `"minUI5Version"` in `manifest.json`.
214214
When configuring local web server, make sure it responds to the exact UI5 version defined in manifest.json e.g `<your.local.web.server>/1.111.0`
215215

216216
**Note**: Once online, UI5 Language Assistant also caches required resources for offline usage and performance optimization.

packages/vscode-ui5-language-assistant/src/extension.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ async function updateCurrentModel(model: UI5Model | undefined): Promise<void> {
212212
if (response) {
213213
version = `${version} (local)`;
214214
tooltipText =
215-
"Alternative (local) SAP UI5 web server is defined in user or workspace settings. Using SAP UI5 version fetched from the local server";
215+
"Alternative (local) SAPUI5 web server is defined in user or workspace settings. Using SAPUI5 version fetched from the local server";
216216
}
217217
}
218218
statusBarItem.tooltip = tooltipText;
@@ -234,7 +234,7 @@ function handleContextError(error: Error & { code?: string }) {
234234
showedOnce = true;
235235
if (error.code) {
236236
window.showErrorMessage(
237-
"[SAP UI5 SDK](https://tools.hana.ondemand.com/#sapui5) is not accessible. Connect to the internet or setup local web server for offline work."
237+
"[SAPUI5 SDK](https://tools.hana.ondemand.com/#sapui5) is not accessible. Connect to the internet or setup local web server for offline work."
238238
);
239239
} else {
240240
window.showErrorMessage(

test-packages/test-utils/src/utils/semantic-model-provider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const MODEL_CACHE: Record<TestModelVersion, UI5SemanticModel> =
1414
Object.create(null);
1515

1616
const fixes: Record<TestModelVersion, TypeNameFix> = {
17-
"1.71.70": {
17+
"1.71.72": {
1818
array: "any[]",
1919
Array: "any[]",
2020
bloolean: undefined,
@@ -258,7 +258,7 @@ type LibraryFix = (content: Json) => void;
258258

259259
// Library version -> library name -> fix function
260260
const libraryFixes: Record<TestModelVersion, Record<string, LibraryFix[]>> = {
261-
"1.71.70": {},
261+
"1.71.72": {},
262262
"1.84.41": {},
263263
"1.96.27": {
264264
"sap.ui.mdc": [

0 commit comments

Comments
 (0)