Skip to content

[SF][SplitButton]: [SplitButton requires two presses of Enter or Space to be activated] #11115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
tandan0813 opened this issue Mar 17, 2025 · 4 comments · May be fixed by #11197
Open
1 task done

[SF][SplitButton]: [SplitButton requires two presses of Enter or Space to be activated] #11115

tandan0813 opened this issue Mar 17, 2025 · 4 comments · May be fixed by #11197
Assignees
@hinzzx
Labels
bug This issue is a bug in the code TOPIC B

Comments

@tandan0813
Copy link

Describe the bug

Please see the isolated example: https://stackblitz.com/edit/github-2or1936m?file=src%2FApp.tsx
In tab navigation, the button can be activated once by pressing Enter or Space. However, when using Shift + Tab, the split button requires two presses of Enter or Space to be activated.

Isolated Example

https://stackblitz.com/edit/github-2or1936m?file=src%2FApp.tsx

Reproduction steps

  1. Open the isolated example
  2. Tab to the splitButton and then keep tab to focus the other element
  3. Using Shift + Tab to focus back to the splitButton
  4. Need two presses of Enter or Space to activate the button

Expected Behaviour

No response

Screenshots or Videos

No response

UI5 Web Components for React Version

2.8.0

UI5 Web Components Version

2.8.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output



Organization


No response


Declaration


    

  •  I’m not disclosing any internal or sensitive information.
    • 


      		
    

      
  





        



            
            

              
            

        

      


      
    








      

    



      

  
            


    







      

  
      



  

  @MarcusNotheis





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  


  

    

  





      


        


  
    

      
          
Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  

    
  
    
    

  

  


    












      

  
            

    

      
    

    


      

          @MarcusNotheis
MarcusNotheis




        transferred this issue from SAP/ui5-webcomponents-react


      Mar 17, 2025

    

  



    


    


    


    







      

  
      



  

  @nnaydenow





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  





      


        


  
    

      
          
Hello @SAP/ui5-webcomponents-topic-b,


The issue is reproducible in the provided snippix.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  

    
  
    
    

  

  


    












      

  
            

    

      
    

    


      

          @nnaydenow
nnaydenow




          added
  the 

  bug

  This issue is a bug in the code
 label


      Mar 17, 2025

    

  



    

    

      
    

    


      

          @hinzzx
hinzzx




              self-assigned this


      Mar 18, 2025

    

  



    

    

      
    

    


      

          @hinzzx
hinzzx




          moved this from New Issues
  to In Progress
  in Maintenance - Topic B


      Mar 18, 2025

    

  








      

  
      



  

  @hinzzx





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

      

      
            hinzzx
  

      

      

      commented


        Mar 18, 2025


      
    


  





      


        


  
    

      
          
Hello @tandan0813 ,


By using Chrome, on Windows machine, I am not able to reproduce the issue.


Could you please confirm that I understood correctly the reproduction steps and the issue itself ?


    

  1. Navigating to the Split Button, using Tab.
    2. 

  2. Then press Tab again in order to move out from the Split Button.
    3. 

  3. Then by using Shift + Tab go back to the Split Button.
    4. 

  4. Try to activate the button with keyboard (Enter or Space).
    5. 



Following those steps on your end requires to press Space or Enter two times in order to activate the Button's main action ? Is that correct ?


Here is a video of me trying to reproduce the issue.



  
    
    2025-03-18_15-17-09.mp4
    
  

  




Best Regards,

Stoyan

      		
    

  





        


            

            
            

              
            

        

      


      

            
  

    
  
    
    

  

  


    












      

  
            







      

  
      



  

  @hinzzx





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

      

      
            hinzzx
  

      

      

      commented


        Mar 20, 2025


      
  •

  

    
      

        
          edited
          
        
        
      

    
    
      
        
      Loading

    
  



    


  





      


        


  
    

      
          
Hi @tandan0813,


After a discussion with @nnaydenow  we managed to reproduce the issue.


The issue is actually that an event is not being thrown the first time we focus out of the split button and then focus in again using Shift + Tab combination. We're working on a fix.


Best Regards,

Stoyan.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  

    
  
    
    

  

  


    












      

  
          

  

    
  


  

      

    @hinzzx
hinzzx



    linked a pull request
    
      Mar 26, 2025
    

    that will
    close
    this issue





  


  

      
   Draft

  







  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @hinzzx
  
    hinzzx
    

      








      


  


  

    Labels
  



    

      

    bug

  This issue is a bug in the code
  

    TOPIC B









      

  

    

        

    Projects
  


        




        
  

    

      
          
        Maintenance - Topic B
    

    

      

            
    Status: In Progress


      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  




            
  
Successfully merging a pull request may close this issue.





    


  
          
      fix(ui5-split-button): fire click event when focused with shift + tab

    
      SAP/ui5-webcomponents
    





      
    

  




      

    

  
      

  

    

      4 participants
    

    

        
          @MarcusNotheis 
        
          @tandan0813 
        
          @nnaydenow 
        
          @hinzzx