Skip to content

[DatePicker]: min-width: 12.5625rem is not general case #11561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
gnseo opened this issue May 22, 2025 · 2 comments · Fixed by #11602
Closed
1 task done

[DatePicker]: min-width: 12.5625rem is not general case #11561

gnseo opened this issue May 22, 2025 · 2 comments · Fixed by #11602
Assignees
Labels
bug This issue is a bug in the code TOPIC B

Comments

@gnseo
Copy link
Contributor

gnseo commented May 22, 2025

Bug Description

The column's width is set as 8rem which is enough for the date format output.
But the DatePicker itself sets the min-width CSS property additionally as 12.5625rem.

So the rest of right side is hidden in this case.
Image

I think it's unnecessary since there is calc(var(--_ui5_input_min_width) + var(--_ui5_input_icon_width)) already.

min-width: calc(var(--_ui5_input_min_width) + var(--_ui5_input_icon_width));

Image

Affected Component

DatePicker

Expected Behaviour

Image

Image

Isolated Example

No response

Steps to Reproduce

No response

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

2.10.0

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@gnseo gnseo added the bug This issue is a bug in the code label May 22, 2025
@nnaydenow
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-b,

Could you please check the issue?

It's more visible when you change min-width of the component when it has value state set as:

Image

Input component has min-width set to 2rem / 2.75rem based on the compact density + visible icons width.

Regards,
Nayden

@didip1000 didip1000 self-assigned this May 23, 2025
didip1000 added a commit that referenced this issue May 29, 2025
Removed a `min-width` style from the DatePicker input that was overriding the value defined in the VD specs.

Fixes: #11561
@github-project-automation github-project-automation bot moved this from New Issues to Completed in Maintenance - Topic B May 29, 2025
Copy link

This issue has been closed. To reopen, just leave a comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code TOPIC B
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants