Skip to content

[Toast]: Disappearing of the toast message also closes the responsive popover #11554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
Vir-Mittal opened this issue May 20, 2025 · 2 comments · May be fixed by #11614
Open
1 task done

[Toast]: Disappearing of the toast message also closes the responsive popover #11554

Vir-Mittal opened this issue May 20, 2025 · 2 comments · May be fixed by #11614
Assignees
@StefanDimitrov04
Labels
bug This issue is a bug in the code TOPIC RL

Comments

@Vir-Mittal
Copy link

Bug Description

When a toast message is inside a responsive popover, and the toast message appears and then disappears, the responsive popover also closes.

This only happens if the toast message is a child of the popover component
This does not happen if the toast component is placed outside the popover component

Affected Component

Toast

Expected Behaviour

The responsive popover should not close

Isolated Example

https://stackblitz.com/edit/github-uakprv7g?file=src%2FApp.tsx

Steps to Reproduce

  1. Open a responsive popover
  2. Click a button inside the popover to show a toast message
  3. Once the toast message disappears, the popover also closes

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

2.10

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Vir-Mittal Vir-Mittal added the bug This issue is a bug in the code label May 20, 2025
@LidiyaGeorgieva
Copy link
Contributor

LidiyaGeorgieva commented May 21, 2025 •
edited
Loading

Hello @Vir-Mittal ,

The stackblitz sample you provided shows empty screen.
I tried to isolate the usage of Toast inside Responsive Popover you described and there is no issue - the Responsive Popover stays open after the Toast closes.
You can see the example here.

Regards,
Lidiya

@nnaydenow
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rl,

Could you please check the issue?

Here is a reproducible example

The close event of ui5-toast triggers close event of ui5-responsive-popover

Regards,
Nayden

@StefanDimitrov04 StefanDimitrov04 self-assigned this May 22, 2025
@StefanDimitrov04 StefanDimitrov04 moved this from New Issues to In progress in Maintenance - Topic RL May 22, 2025
@StefanDimitrov04 StefanDimitrov04 linked a pull request May 29, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanDimitrov04 StefanDimitrov04

Labels
bug This issue is a bug in the code TOPIC RL
Projects
Maintenance - Topic RL
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(ui5-toast): prevent bubbling on close SAP/ui5-webcomponents
4 participants
@LidiyaGeorgieva @nnaydenow @Vir-Mittal @StefanDimitrov04