Skip to content

Commit 5501db4

Browse files
authored
Merge pull request #10 from ScrapingAnt/feature/issue7-fix-user-agent
feature/issue7-fix-user-agent: changed version file approach
2 parents 08d71b6 + cb43e5f commit 5501db4

File tree

6 files changed

+11
-10
lines changed

6 files changed

+11
-10
lines changed

MANIFEST.in

-1
This file was deleted.

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -130,5 +130,5 @@ print(result.content)
130130
```
131131

132132
## Useful links
133-
- [Scrapingant Api doumentation](https://docs.scrapingant.com)
134-
- [Scrapingant Js Client](https://github.com/scrapingant/scrapingant-client-js)
133+
- [Scrapingant API doumentation](https://docs.scrapingant.com)
134+
- [Scrapingant JS Client](https://github.com/scrapingant/scrapingant-client-js)

scrapingant_client/VERSION

-1
This file was deleted.

scrapingant_client/__init__.py

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
__version__ = "0.3.3"
2+
13
from scrapingant_client.client import ScrapingAntClient
24
from scrapingant_client.cookie import Cookie
35
from scrapingant_client.errors import (

scrapingant_client/client.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
import os
21
import platform
32
import sys
43
from typing import List, Optional
54

65
import requests
76

7+
import scrapingant_client
88
from scrapingant_client.constants import SCRAPINGANT_API_BASE_URL
99
from scrapingant_client.cookie import Cookie, cookies_list_to_string, cookies_list_from_string
1010
from scrapingant_client.errors import (
@@ -20,8 +20,7 @@ class ScrapingAntClient:
2020
def __init__(self, token: str):
2121
self.token = token
2222
self.requests_session = requests.Session()
23-
version_file = open(os.path.join('scrapingant_client', 'VERSION'))
24-
version = version_file.read().strip()
23+
version = scrapingant_client.__version__
2524
user_agent = f'ScrapingAnt Client/{version} ({sys.platform}; Python/{platform.python_version()});'
2625
self.requests_session.headers.update({
2726
'x-api-key': self.token,

setup.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
import os
2+
import pathlib
3+
import re
24

35
import setuptools
46

57
with open("README.md", "r", encoding="utf-8") as fh:
68
long_description = fh.read()
79

8-
version_file = open(os.path.join('scrapingant_client', 'VERSION'))
9-
version = version_file.read().strip()
10+
HERE = pathlib.Path(__file__).parent
11+
txt = (HERE / "scrapingant_client" / "__init__.py").read_text("utf-8")
12+
version = re.findall(r'^__version__ = "([^"]+)"\r?$', txt, re.M)[0]
1013

1114
setuptools.setup(
1215
name="scrapingant-client",
@@ -40,5 +43,4 @@
4043
'responses>=0,<1'
4144
]
4245
},
43-
include_package_data=True,
4446
)

0 commit comments

Comments
 (0)