Bug#37471922: Auto-fix clang-tidy warnings [73/n] [noclose]

Generate fixes for a number of warnings that clang-tidy can fix automatically.
This commit fixes the warning 'performance-unnecessary-value-param'.

Change example:
 - void create_file(std::string path) {
 + void create_file(const std::string &path) {

Change-Id: Ic2468b38de8fad4297b2ac2294bb0a25dcc78ad5

Author: MRajcic

client/check/mysqlcheck_core.cc

@@ -27,6 +27,7 @@
 #include <mysqld_error.h>
 #include <sys/types.h>
 #include <string>
+#include <utility>
 #include <vector>
 
 #include "client/check/mysqlcheck.h"
@@ -387,7 +388,7 @@ void mysql_check(MYSQL *connection, int what_to_do, bool opt_alldbs,
   ::opt_upgrade = opt_upgrade;
   ::opt_write_binlog = opt_write_binlog;
   ::verbose = verbose;
-  ::opt_skip_database = opt_skip_database;
+  ::opt_skip_database = std::move(opt_skip_database);
   ::DBError = dberror;
 
   if (!::opt_write_binlog) {

client/mysqldump.cc

@@ -812,19 +812,19 @@ static std::unordered_map<string, string> compatibility_rpl_replica_commands = {
 static std::unordered_map<string, string> compatibility_rpl_source_commands = {
     {"SHOW BINARY LOG STATUS", "SHOW MASTER STATUS"}};
 
-static string get_compatible_rpl_source_query(string command) {
+static string get_compatible_rpl_source_query(const string &command) {
   return ((opt_server_version < FIRST_REPLICA_COMMAND_VERSION)
               ? compatibility_rpl_source_commands.at(command)
               : command);
 }
 
-static string get_compatible_rpl_replica_query(string command) {
+static string get_compatible_rpl_replica_query(const string &command) {
   return ((opt_server_version < FIRST_REPLICA_COMMAND_VERSION)
               ? compatibility_rpl_replica_commands.at(command)
               : command);
 }
 
-static string get_compatible_rpl_replica_command(string command) {
+static string get_compatible_rpl_replica_command(const string &command) {
   return ((opt_output_as_version_mode == Output_as_version_mode::BEFORE_8_0_23)
               ? compatibility_rpl_replica_commands.at(command)
               : command);

client/mysqltest.cc

@@ -66,6 +66,7 @@
 #include <cstdarg>
 #include <cstdio>
 #include <cstdlib>
+#include <utility>
 #ifndef _WIN32
 #include <poll.h>
 #include <sys/time.h>
@@ -678,7 +679,9 @@ static void free_all_replace() {
 class AsyncTimer {
  public:
   explicit AsyncTimer(std::string label)
-      : label_(label), time_(std::chrono::system_clock::now()), start_(time_) {}
+      : label_(std::move(label)),
+        time_(std::chrono::system_clock::now()),
+        start_(time_) {}
 
   ~AsyncTimer() {
     auto now = std::chrono::system_clock::now();
@@ -5948,7 +5951,8 @@ static bool check_and_filter_once_property(DYNAMIC_STRING ds_property,
 /// @param once_prop    Flag specifying whether a property should be set
 ///                     for next statement only.
 static void handle_disable_warnings(std::uint32_t warning_code,
-                                    std::string warning, bool once_prop) {
+                                    const std::string &warning,
+                                    bool once_prop) {
   if (enabled_warnings->count()) {
     // Remove the warning from list of enabled warnings.
     enabled_warnings->remove_warning(warning_code, once_prop);
@@ -5973,7 +5977,7 @@ static void handle_disable_warnings(std::uint32_t warning_code,
 /// @param once_prop    Flag specifying whether a property should be set
 ///                     for next statement only.
 static void handle_enable_warnings(std::uint32_t warning_code,
-                                   std::string warning, bool once_prop) {
+                                   const std::string &warning, bool once_prop) {
   if (disabled_warnings->count()) {
     // Remove the warning from list of disabled warnings.
     disabled_warnings->remove_warning(warning_code, once_prop);
@@ -8641,7 +8645,7 @@ static bool match_warnings(Expected_warnings *warnings, std::uint32_t error,
 ///
 /// @retval True if a warning is found in the list of disabled or enabled
 ///         warnings, false otherwise.
-static bool handle_one_warning(DYNAMIC_STRING *ds, std::string warning) {
+static bool handle_one_warning(DYNAMIC_STRING *ds, const std::string &warning) {
   // Each line of show warnings output contains information about
   // error level, error code and the error/warning message separated
   // by '\t'. Parse each line from the show warnings output to
@@ -11584,7 +11588,7 @@ class Comp_lines {
   }
 };
 
-static size_t length_of_n_first_columns(std::string str,
+static size_t length_of_n_first_columns(const std::string &str,
                                         int start_sort_column) {
   std::stringstream columns(str);
   std::string temp;

client/mysqltest/error_names.cc

@@ -31,7 +31,7 @@ static st_error global_error_names[] = {
 #endif /* IN_DOXYGEN */
     {nullptr, 0, nullptr, nullptr, nullptr, 0}};
 
-int get_errcode_from_name(std::string error_name) {
+int get_errcode_from_name(const std::string &error_name) {
   for (st_error *error = global_error_names; error->name; error++) {
     if (error_name == error->name) return error->error_code;
   }

client/mysqltest/error_names.h

@@ -40,7 +40,7 @@ struct st_error {
 /// @param error_name Error name string
 ///
 /// @retval -1 if error name is unknown, error code otherwise.
-int get_errcode_from_name(std::string error_name);
+int get_errcode_from_name(const std::string &error_name);
 
 /// Get an error name from an error code.
 ///

components/keyrings/common/data/data.cc

@@ -22,6 +22,7 @@
    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301  USA */
 
 #include <functional>
+#include <utility>
 
 #include "data.h"
 
@@ -35,7 +36,7 @@ Data::Data(const Sensitive_data &data, Type type)
 
 /* Following constructors imply no data */
 Data::Data() : Data("", "") {}
-Data::Data(Type type) : Data("", type) {}
+Data::Data(Type type) : Data("", std::move(type)) {}
 
 /** Copy constructor */
 Data::Data(const Data &src) : Data(src.data_, src.type_) {}

components/keyrings/common/json_data/json_reader.cc

@@ -114,7 +114,7 @@ Json_reader::Json_reader() : Json_reader(schema_version_1_0, "") {}
   @returns property value string in case property is present,
   empty string otherwise.
 */
-std::string Json_reader::property(const std::string property_key) const {
+std::string Json_reader::property(const std::string &property_key) const {
   if (!valid_) return {};
   return document_[property_key.c_str()].Get<std::string>();
 }

components/keyrings/common/json_data/json_reader.h

@@ -127,7 +127,7 @@ class Json_reader {
 
     @returns value of the property
   */
-  std::string property(const std::string property_key) const;
+  std::string property(const std::string &property_key) const;
 
  private:
   /** Data in JSON DOM format */

components/libminchassis/mysql_component.cc

@@ -24,11 +24,12 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301  USA */
 #include "mysql_component_imp.h"
 
 #include <cstddef>
+#include <utility>
 #include <vector>
 
 mysql_component::mysql_component(mysql_component_t *component_data,
                                  my_string urn)
-    : m_component_data(component_data), m_urn(urn) {
+    : m_component_data(component_data), m_urn(std::move(urn)) {
   for (const mysql_metadata_ref_t *metadata_iterator = component_data->metadata;
        metadata_iterator->key != nullptr; ++metadata_iterator) {
     this->set_value(metadata_iterator->key, metadata_iterator->value);

components/test/perfschema/test_pfs_notification.cc

@@ -99,7 +99,7 @@ static bool negative_tests = false;
 /* Callback for special use case */
 void session_connect_internal(const PSI_thread_attrs *thread_attrs);
 
-void print_log(std::string msg);
+void print_log(const std::string &msg);
 
 /**
   Log file operations
@@ -119,7 +119,7 @@ void close_log() {
   if (log_outfile.is_open()) log_outfile.close();
 }
 
-void print_log(std::string msg) {
+void print_log(const std::string &msg) {
   if (!log_enabled) return;
 
   /* Write to both log file and stderr. */

components/test/perfschema/test_pfs_resource_group.cc

@@ -82,7 +82,7 @@ static int handle = 0;
 static std::ofstream log_outfile;
 static std::string separator("===========================");
 
-void print_log(std::string msg) {
+void print_log(const std::string &msg) {
   log_outfile << msg << std::endl;
   fprintf(stderr, "%s\n", msg.c_str());
   fflush(stderr);

components/test/statement_services/utils.cc

@@ -177,7 +177,7 @@ auto parse_rows(my_h_statement statement, size_t fields_count,
 
 // Make a string where values are separated by separator
 auto string_from_vector(const std::vector<std::string> &values,
-                        const std::string separator) -> std::string {
+                        const std::string &separator) -> std::string {
   auto temp = std::string{};
   auto first = true;
   for (const auto &header : values) {

include/compression.h

@@ -48,13 +48,13 @@ constexpr int default_zstd_compression_level = 3;
 
 /* Helper functions to validate compression algorithm and level */
 enum_compression_algorithm get_compression_algorithm(
-    std::string name = std::string());
+    const std::string &name = std::string());
 std::string get_compression_algorithm_name(enum_compression_algorithm);
-void parse_compression_algorithms_list(std::string name,
+void parse_compression_algorithms_list(const std::string &name,
                                        std::vector<std::string> &list);
 bool is_zstd_compression_level_valid(uint level);
-bool validate_compression_attributes(std::string algorithm_names,
-                                     std::string channel_name,
+bool validate_compression_attributes(const std::string &algorithm_names,
+                                     const std::string &channel_name,
                                      bool ignore_errors);
 
 #endif /* COMPRESSION_INCLUDED */

include/my_sys.h

@@ -957,8 +957,8 @@ extern void set_psi_tls_channel_service(void *psi);
 [[nodiscard]] extern unsigned long long my_physical_memory();
 
 /* Compares versions and determine if clone is allowed */
-[[nodiscard]] extern bool are_versions_clone_compatible(std::string ver1,
-                                                        std::string ver2);
+[[nodiscard]] extern bool are_versions_clone_compatible(
+    const std::string &ver1, const std::string &ver2);
 
 /**
   @} (end of group MYSYS)

libmysql/authentication_kerberos/auth_kerberos_client_plugin.cc

@@ -34,6 +34,7 @@
 #include <cstdio>
 #include <cstdlib>
 #include <cstring>
+#include <utility>
 
 #include <mysql.h>
 #include <mysql/client_plugin.h>
@@ -81,7 +82,7 @@ bool Kerberos_plugin_client::obtain_store_credentials() {
 }
 
 void Kerberos_plugin_client::set_mysql_account_name(
-    std::string mysql_account_name) {
+    const std::string &mysql_account_name) {
   std::string cc_user_name;
   std::stringstream log_client_stream;
 
@@ -141,17 +142,18 @@ void Kerberos_plugin_client::set_mysql_account_name(
   }
 }
 
-void Kerberos_plugin_client::set_upn_info(std::string name, std::string pwd) {
+void Kerberos_plugin_client::set_upn_info(const std::string &name,
+                                          std::string pwd) {
   /*
     Setting UPN using MySQL account name + user realm.
   */
-  m_password = pwd;
+  m_password = std::move(pwd);
   if (!name.empty()) {
     create_upn(name);
   }
 }
 
-void Kerberos_plugin_client::create_upn(std::string account_name) {
+void Kerberos_plugin_client::create_upn(const std::string &account_name) {
   if (!m_as_user_relam.empty()) {
     m_user_principal_name = account_name + "@" + m_as_user_relam;
   }

libmysql/authentication_kerberos/auth_kerberos_client_plugin.h

@@ -50,13 +50,13 @@ class Kerberos_plugin_client {
                          authentication_mode mode);
   ~Kerberos_plugin_client() = default;
   bool authenticate();
-  void set_upn_info(std::string name, std::string pwd);
-  void set_mysql_account_name(std::string name);
+  void set_upn_info(const std::string &name, std::string pwd);
+  void set_mysql_account_name(const std::string &name);
   bool obtain_store_credentials();
   bool read_spn_realm_from_server();
 
  protected:
-  void create_upn(std::string account_name);
+  void create_upn(const std::string &account_name);
   std::string m_user_principal_name;
   std::string m_password;
   std::string m_service_principal;

libmysql/authentication_kerberos/log_client.cc

@@ -27,7 +27,7 @@ void Logger_client::set_log_level(log_client_level level) {
   m_log_level = level;
 }
 
-void Logger_client::write(std::string data) {
+void Logger_client::write(const std::string &data) {
   std::cerr << data << "\n";
   std::cerr.flush();
 }

libmysql/authentication_kerberos/log_client.h

@@ -50,7 +50,7 @@ class Logger_client {
   template <log_client_type::log_type type>
   void log(std::string msg);
   void set_log_level(log_client_level level);
-  void write(std::string data);
+  void write(const std::string &data);
   void log_client_plugin_data_exchange(const unsigned char *buffer,
                                        unsigned int length);
 

libmysql/fido_client/common/registration.cc

@@ -66,7 +66,7 @@ bool registration::make_credentials(const char *challenge) {
 
   @param [in] user   buffer holding user name
 */
-void registration::set_user(std::string user) {
+void registration::set_user(const std::string &user) {
   /*
     1, 2 parameters refer to user ID/len, which should be unique for
     a given user, else same credentials is re used in authenticator.
@@ -81,7 +81,7 @@ void registration::set_user(std::string user) {
 
   @param [in] rp_id   buffer holding relying party name
 */
-void registration::set_rp_id(std::string rp_id) {
+void registration::set_rp_id(const std::string &rp_id) {
   fido_cred_set_rp(m_cred, rp_id.c_str(), nullptr);
 }
 

libmysql/fido_client/common/registration.h

@@ -53,9 +53,9 @@ class registration {
   virtual ~registration();
   bool make_credentials(const char *challenge);
   /* set rp id */
-  void set_rp_id(std::string rp_id);
+  void set_rp_id(const std::string &rp_id);
   /* set user name */
-  void set_user(std::string user);
+  void set_user(const std::string &user);
 
   /* get authenticator data details */
   size_t get_authdata_len();

mysys/my_version.cc

@@ -109,7 +109,8 @@ static ParseArray parse_version_string(std::string version, bool &is_valid) {
  @param ver2 version2 string
  @return true if cloning is allowed between ver1 and ver2, false otherwise
  */
-bool are_versions_clone_compatible(std::string ver1, std::string ver2) {
+bool are_versions_clone_compatible(const std::string &ver1,
+                                   const std::string &ver2) {
   if (ver1 == ver2) {
     return true;
   }

plugin/clone/src/clone_plugin.cc

@@ -182,7 +182,7 @@ using Donor_Callback = std::function<bool(std::string &, uint32_t)>;
 @param[in]	callback	callback function
 @return true, if scan is successful or match is found. */
 static bool scan_donor_list(const std::string &donor_list,
-                            Donor_Callback callback) {
+                            const Donor_Callback &callback) {
   size_t comma_pos = 0;
   size_t begin_pos = 0;
 
@@ -318,7 +318,9 @@ static int check_donor_addr_format(MYSQL_THD thd, SYS_VAR *var [[maybe_unused]],
 
   const std::string addrs(addrs_cstring);
 
-  Donor_Callback const callback = [](std::string, uint32_t) { return (false); };
+  const Donor_Callback callback = [](const std::string &, uint32_t) {
+    return (false);
+  };
 
   bool const success = scan_donor_list(addrs_cstring, callback);
 

plugin/group_replication/include/sql_service/sql_service_interface.h

@@ -143,7 +143,7 @@ class Sql_service_interface {
       @retval >0    SQL Error Number returned from MySQL Service API
       @retval <0    local errors
   */
-  long execute_query(std::string query_string);
+  long execute_query(const std::string &query_string);
 
   /**
     Executes a server command in a session.
@@ -163,7 +163,7 @@ class Sql_service_interface {
       @retval <0    local errors
   */
   long execute_query(
-      std::string sql_string, Sql_resultset *rset,
+      const std::string &sql_string, Sql_resultset *rset,
       enum cs_text_or_binary cs_txt_bin = CS_TEXT_REPRESENTATION,
       const CHARSET_INFO *cs_charset = &my_charset_utf8mb3_general_ci);