Bug#37692054 Do not use c_ptr_safe() [noclose]

Do not use String::c_ptr_safe(), it has unclear semantics.
See comments in the source code.

Change-Id: I1da3fea12d8d3d9ebad23658a89da8a7655d5eb9

Author: Tor Didriksen

plugin/group_replication/src/perfschema/table_replication_group_configuration_version.cc

@@ -169,7 +169,7 @@ PSI_table_handle *Pfs_table_replication_group_configuration_version::open_table(
       struct Replication_group_configuration_version row;
 
       table->field[0]->val_str(&string);
-      row.name.assign(string.c_ptr_safe(), string.length());
+      row.name.assign(to_string_view(string));
 
       row.version = table->field[1]->val_int();
 

plugin/group_replication/src/perfschema/table_replication_group_member_actions.cc

@@ -190,20 +190,20 @@ PSI_table_handle *Pfs_table_replication_group_member_actions::open_table(
       struct Replication_group_member_actions row;
 
       table->field[0]->val_str(&string);
-      row.name.assign(string.c_ptr_safe(), string.length());
+      row.name.assign(to_string_view(string));
 
       table->field[1]->val_str(&string);
-      row.event.assign(string.c_ptr_safe(), string.length());
+      row.event.assign(to_string_view(string));
 
       row.enabled = table->field[2]->val_int();
 
       table->field[3]->val_str(&string);
-      row.type.assign(string.c_ptr_safe(), string.length());
+      row.type.assign(to_string_view(string));
 
       row.priority = table->field[4]->val_int();
 
       table->field[5]->val_str(&string);
-      row.error_handling.assign(string.c_ptr_safe(), string.length());
+      row.error_handling.assign(to_string_view(string));
 
       t->rows.push_back(row);
     } while (!key_access.next());

plugin/group_replication/src/plugin_handlers/member_actions_handler_configuration.cc

@@ -82,10 +82,10 @@ Member_actions_handler_configuration::enable_disable_action(
   char buffer[MAX_FIELD_WIDTH];
   String string(buffer, sizeof(buffer), &my_charset_bin);
   table->field[3]->val_str(&string);
-  std::string type(string.c_ptr_safe(), string.length());
+  std::string type = to_string(string);
   uint priority = static_cast<uint>(table->field[4]->val_int());
   table->field[5]->val_str(&string);
-  std::string error_handling(string.c_ptr_safe(), string.length());
+  std::string error_handling = to_string(string);
 
   // delete row
   error |= table->file->ha_delete_row(table->record[0]);
@@ -188,21 +188,21 @@ bool Member_actions_handler_configuration::get_actions_for_event(
       protobuf_replication_group_member_actions::Action *action =
           action_list.add_action();
       table->field[0]->val_str(&string);
-      action->set_name(string.c_ptr_safe(), string.length());
+      action->set_name(to_string(string));
 
       table->field[1]->val_str(&string);
-      action->set_event(string.c_ptr_safe(), string.length());
+      action->set_event(to_string(string));
 
       action->set_enabled(table->field[2]->val_int());
 
       table->field[3]->val_str(&string);
-      action->set_type(string.c_ptr_safe(), string.length());
+      action->set_type(to_string(string));
 
       uint priority = static_cast<uint>(table->field[4]->val_int());
       action->set_priority(priority);
 
       table->field[5]->val_str(&string);
-      action->set_error_handling(string.c_ptr_safe(), string.length());
+      action->set_error_handling(to_string(string));
     } while (!key_access.next());
   } else if (HA_ERR_END_OF_FILE == key_error) {
     /* Table is empty, nothing to read. */
@@ -265,21 +265,21 @@ bool Member_actions_handler_configuration::get_all_actions_internal(
       protobuf_replication_group_member_actions::Action *action =
           action_list.add_action();
       table->field[0]->val_str(&string);
-      action->set_name(string.c_ptr_safe(), string.length());
+      action->set_name(to_string(string));
 
       table->field[1]->val_str(&string);
-      action->set_event(string.c_ptr_safe(), string.length());
+      action->set_event(to_string(string));
 
       action->set_enabled(table->field[2]->val_int());
 
       table->field[3]->val_str(&string);
-      action->set_type(string.c_ptr_safe(), string.length());
+      action->set_type(to_string(string));
 
       uint priority = static_cast<uint>(table->field[4]->val_int());
       action->set_priority(priority);
 
       table->field[5]->val_str(&string);
-      action->set_error_handling(string.c_ptr_safe(), string.length());
+      action->set_error_handling(to_string(string));
     } while (!key_access.next());
   } else if (HA_ERR_END_OF_FILE == key_error) {
     /* Table is already empty, nothing to read. */