Bug#36235275 test_event -n Bug44915 T1, error insert 13031, 13044, 13045 are never hit

Various issues here :

 1.  Those error inserts are not hit as they are in SUMA execSUB_CREATE_REQ()
     which is only executed on SUMA when a Subscriber (aka EventOperation) is
     created.
     Just creating the Event is not enough to trigger them, so the test
     covers nothing and naturally they would be left behind when it finishes.

     Solution :
       - Add create EventOperation and check that it fails

 2.  The other error inserts (error2) are related to SUMA Scans, where it
     asks DIH to get distribution info.  The error inserts are intended
     to give code coverage of some 'many fragments' continueB cases.

     a) This has nothing to do with Events
     b) Creating and Dropping events does not involve scanning

     Solution :
       - Split into separate testcase
       - Add index creation which *will* trigger a SUMA scan and will
         cause these error insertions to be hit.

 3.  Error insert 13049 causes a crash when hit.
     This error insert triggers a CONTINUEB, but then carries on with
     the scan.
     When the CONTINUEB arrives, the scan is not in the correct state
     causing a crash.
     Fix by having the code return after queueing the CONTINUEB.

Summary :
  Testcase was a mess, testing nothing.
  Error insert being left behind was a good indicator of a problem.

New test :
  test_event -n SumaScanGetNodesContinueB T1 added to daily-basic--03

Change-Id: I4c4470cc6ef2a53dd470a4e4ac90ca1085504140

Author: frazerclement

storage/ndb/src/kernel/blocks/suma/Suma.cpp

@@ -2966,6 +2966,7 @@ Suma::sendDIGETNODESREQ(Signal *signal,
       signal->theData[3] = fragNo + 1;
       sendSignal(reference(), GSN_CONTINUEB, signal,
                  4, JBB);
+      return;
     }
   }
   jam();

storage/ndb/test/ndbapi/test_event.cpp

@@ -4905,26 +4905,93 @@ runBug44915(NDBT_Context* ctx, NDBT_Step* step)
   int result = NDBT_OK;
 
   NdbRestarter res;
-  int error[] = { 13031, 13044, 13045, 13031, 0 };
-  int error2[] = { 13049, 13050, 13049, 13050, 0 };
   /**
-   * error2 is used to test CONTINUEB handling when reading table
-   * fragmentation, it is not expected to give any faults.
+   * Test various failures in SUMA::SUB_CREATE_REQ which
+   * is invoked when a subscription is setup
+   * (A side effect of the first subscriber (EventOperation)
+   * being created)
    */
+  int error[] = {13031, /* SUMA SUB_CREATE_REQ Table::UNDEFINED */
+                 13044, /* SUMA SUB_CREATE_REQ Out of op records */
+                 13045, /* SUMA SUB_CREATE_REQ Out of table records */
+                 13031, /* SUMA SUB_CREATE_REQ Table::UNDEFINED */
+                 0};
   for (int i = 0; error[i] && result == NDBT_OK; i++)
   {
     Uint32 nodeId = res.getDbNodeId(rand() % res.getNumDbNodes());
-    ndbout_c("error: %d", error[i]);
-    res.insertErrorInNode(nodeId, error[i]);
-    
-    result = runCreateEvent(ctx, step); // should fail due to error insert
-    res.insertErrorInNode(nodeId, error2[i]);
-    result = runCreateEvent(ctx, step); // should pass
-    result = runDropEvent(ctx, step);
+    {
+      ndbout_c("error: %d on node %u", error[i], nodeId);
+      res.insertErrorInNode(nodeId, error[i]);
+      result = runCreateEvent(ctx, step);
+      NdbEventOperation *pOp = createEventOperation(
+          GETNDB(step), *ctx->getTab(), 1); /* report errors */
+      /* Expect failure */
+      if (pOp != 0) {
+        ndbout_c("Expected failure, but succeeded.");
+        return NDBT_FAILED;
+      }
+      result = runDropEvent(ctx, step);
+    }
   }
   return result;
 }
 
+int runTestSumaScanGetNodesContinueB(NDBT_Context *ctx, NDBT_Step *step) {
+  int result = NDBT_OK;
+
+  NdbRestarter res;
+  const NdbDictionary::Table *pTab = ctx->getTab();
+  Ndb *pNdb = GETNDB(step);
+
+  /**
+   * Get code coverage of a SUMA-internal CONTINUEB path
+   * when requesting distribution info for table fragments
+   * being scanned
+   */
+  int error[] = {13049, /* SUMA CONTINUEB::WAIT_GET_FRAGMENT (last fragment) */
+                 13050, /* SUMA CONTINUEB::WAIT_GET_FRAGMENT (first fragment) */
+                 13049, 13050, 0};
+  /**
+   * error is used to test CONTINUEB handling when reading table
+   * fragmentation, it is not expected to give any faults.
+   */
+  for (int i = 0; error[i] && result == NDBT_OK; i++) {
+    Uint32 nodeId = res.getDbNodeId(rand() % res.getNumDbNodes());
+    {
+      ndbout_c("error: %d on node %u", error[i], nodeId);
+      res.insertErrorInNode(nodeId, error[i]);
+
+      /* Cause a SUMA scan to occur, hitting path */
+      /* Build an ordered index on the pk cols */
+      {
+        ndbout_c("Defining index on table");
+        const char *indexName = "SUMAIDX";
+        NdbDictionary::Index idxDef(indexName);
+        idxDef.setTable(pTab->getName());
+        idxDef.setType(NdbDictionary::Index::OrderedIndex);
+        for (int c = 0; c < pTab->getNoOfColumns(); c++) {
+          const NdbDictionary::Column *col = pTab->getColumn(c);
+          if (col->getPrimaryKey()) {
+            ndbout_c("  Adding column %s", col->getName());
+            idxDef.addIndexColumn(col->getName());
+          }
+        }
+        idxDef.setStoredIndex(false);
+
+        if (pNdb->getDictionary()->createIndex(idxDef) != 0) {
+          ndbout_c("Failed to create index with error %u %s",
+                   pNdb->getDictionary()->getNdbError().code,
+                   pNdb->getDictionary()->getNdbError().message);
+          return NDBT_FAILED;
+        }
+        ndbout_c("Created index ok, dropping it");
+        pNdb->getDictionary()->dropIndex(indexName, pTab->getName());
+      }
+    }
+  }
+  return NDBT_OK;
+}
+
 int
 runBug56579(NDBT_Context* ctx, NDBT_Step* step)
 {
@@ -7412,6 +7479,10 @@ TESTCASE("Bug44915", "")
 {
   INITIALIZER(runBug44915);
 }
+TESTCASE("SumaScanGetNodesContinueB", "")
+{
+  STEP(runTestSumaScanGetNodesContinueB);
+}
 TESTCASE("Bug56579", "")
 {
   INITIALIZER(runCreateEvent);

storage/ndb/test/run-test/daily-basic--03-tests.txt

@@ -1,4 +1,4 @@
-# Copyright (c) 2015, 2019, Oracle and/or its affiliates. All rights reserved.
+# Copyright (c) 2015, 2024, Oracle and/or its affiliates. All rights reserved.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -19,6 +19,10 @@ cmd: test_event
 args: -n Bug44915 T1
 max-time: 180
 
+cmd: test_event
+args: -n SumaScanGetNodesContinueB T1
+max-time: 180
+
 cmd: testNdbApi
 args: -n ExecuteAsynch T1
 max-time: 180