Skip to content

Commit 366aacf

Browse files
authored
Only allow .render targets to run reactExtension (#2498)
Merge pull request #2498 from Shopify/bs/fix-reactExtension
2 parents 2be1fb7 + 33b90a4 commit 366aacf

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

.changeset/neat-paws-smile.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@shopify/ui-extensions-react': patch
3+
---
4+
5+
surfaces/admin: the reactExtension will only allow .render targets to run

packages/ui-extensions-react/src/surfaces/admin/render.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,12 @@ export function reactExtension<ExtensionTarget extends RenderExtensionTarget>(
3434
// Playground extension, since all render extensions have the same general
3535
// shape (`RenderExtension`).
3636
return extension<'Playground'>(target as any, async (root, api) => {
37+
if (!target.match(/\.render$/)) {
38+
throw new Error(
39+
`reactExtension can only be used for .render extension targets, got: ${target}`,
40+
);
41+
}
42+
3743
const element = await render(api as ApiForRenderExtension<ExtensionTarget>);
3844

3945
return remoteRootRender(

0 commit comments

Comments
 (0)