Skip to content

Commit 274b570

Browse files
authored
Merge pull request #267 from zm711/probegroup_plot
plot_probe_group -> plot_probegroup
2 parents 3c5dedd + 9eebc20 commit 274b570

File tree

2 files changed

+28
-6
lines changed

2 files changed

+28
-6
lines changed

src/probeinterface/plotting.py

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ def on_press(event):
183183
return poly, poly_contour
184184

185185

186-
def plot_probe_group(probegroup, same_axes: bool = True, **kargs):
186+
def plot_probegroup(probegroup, same_axes: bool = True, **kargs):
187187
"""Plot all probes from a ProbeGroup
188188
Can be in an existing set of axes or separate axes.
189189
@@ -244,6 +244,22 @@ def plot_probe_group(probegroup, same_axes: bool = True, **kargs):
244244
plot_probe(probe, ax=axs[i], **kargs)
245245

246246

247+
def plot_probe_group(probegroup, same_axes: bool = True, **kargs):
248+
"""
249+
This function is deprecated and will be removed in 0.2.23
250+
Please use plot_probegroup instead"""
251+
252+
from warnings import warn
253+
254+
warn(
255+
"`plot_probe_group` is deprecated and will be removed in 2.23. Use plot_probegroup instead",
256+
category=DeprecationWarning,
257+
stacklevel=2,
258+
)
259+
260+
plot_probegroup(probegroup, same_axes=same_axes, **kargs)
261+
262+
247263
def _on_press(probe, event):
248264
ax = event.inaxes
249265
x, y = event.xdata, event.ydata

tests/test_plotting.py

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
from probeinterface import Probe, ProbeGroup
22
from probeinterface import generate_dummy_probe, generate_dummy_probe_group
3-
from probeinterface.plotting import plot_probe, plot_probe_group
3+
from probeinterface.plotting import plot_probe, plot_probegroup
4+
5+
# remove once plot_probe_group is removed
6+
from probeinterface.plotting import plot_probe_group
47

58
import matplotlib.pyplot as plt
69
import numpy as np
@@ -29,18 +32,21 @@ def test_plot_probe():
2932
plot_probe(probe, show_channel_on_click=True)
3033

3134

32-
def test_plot_probe_group():
35+
def test_plot_probegroup():
3336
probegroup = generate_dummy_probe_group()
3437

35-
plot_probe_group(probegroup, same_axes=True, with_contact_id=True)
36-
plot_probe_group(probegroup, same_axes=False)
38+
plot_probegroup(probegroup, same_axes=True, with_contact_id=True)
39+
plot_probegroup(probegroup, same_axes=False)
40+
41+
# remove when plot_probe_group has been removed
42+
plot_probe_group(probegroup)
3743

3844
# 3d
3945
probegroup_3d = ProbeGroup()
4046
for probe in probegroup.probes:
4147
probegroup_3d.add_probe(probe.to_3d())
4248
probegroup_3d.probes[-1].move([0, 150, -50])
43-
plot_probe_group(probegroup_3d, same_axes=True)
49+
plot_probegroup(probegroup_3d, same_axes=True)
4450

4551

4652
if __name__ == "__main__":

0 commit comments

Comments
 (0)