Merge pull request #87 from SpringRoll/release/1.8.0

Release/1.8.0

Author: chipbell4

app/public/js/embed.js

@@ -170,8 +170,9 @@ const start = () => {
       playOptions,
       query: queryArgs.length ? '?' + queryArgs.join('&') : ''
     })
-    .catch(err => err.json())
-    .then(({ error }) => alert(error));
+    .catch(err => {
+      err.json().then(({ error }) => alert(error));
+    })
 };
 
 start();

app/public/js/libraries.js

@@ -3,17 +3,22 @@ window.addEventListener('load', () => {
     '.navbar-brand .version'
   );
 
+  if (versionAndCommitButton === null) {
+    return;
+  }
+
   const version = versionAndCommitButton.dataset.ver;
-  let commitID = versionAndCommitButton.dataset.commit;
+  const commitID = versionAndCommitButton.dataset.commit;
 
-  if (version && commitID) {
-    commitID = commitID.slice(0, 7);
-    versionAndCommitButton.addEventListener('click', function() {
-      if (versionAndCommitButton.textContent === version) {
-        versionAndCommitButton.textContent = commitID;
-      } else {
-        versionAndCommitButton.textContent = version;
-      }
-    });
+  if (!version || !commitID) {
+    return;
   }
+
+  versionAndCommitButton.addEventListener('click', function() {
+    if (versionAndCommitButton.textContent === version) {
+      versionAndCommitButton.textContent = commitID.slice(0, 7);
+    } else {
+      versionAndCommitButton.textContent = version;
+    }
+  });
 });