feat(vscode): add toggle for single language (#3966)

* feat(inline-completion): add toggle for language-specific inline completion

* refactor(command-palette): simplify status and completion item handling

* refactor(status-bar): streamline language check and update logic

* feat(inline-completion): add configuration for disabling code completion by language

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: Sma1lboy

clients/vscode/package.json

@@ -158,6 +158,11 @@
         "icon": "$(history)",
         "enablement": "tabby.chatSidePanelStatus === 'ready'",
         "category": "Tabby"
+      },
+      {
+        "command": "tabby.toggleLanguageInlineCompletion",
+        "title": "Toggle Language Inline Completion",
+        "category": "Tabby"
       }
     ],
     "submenus": [
@@ -373,6 +378,14 @@
                   "Manual trigger by pressing `Alt + \\`"
                 ]
               },
+              "inlineCompletion.disabledLanguages": {
+                "type": "array",
+                "items": {
+                  "type": "string"
+                },
+                "default": [],
+                "description": "List of language IDs for which code completion should be disabled. Use the 'Toggle Single Language Inline Completion' command to easily enable or disable completion for the current language."
+              },
               "chatEdit.history": {
                 "type": "integer",
                 "default": 20,

clients/vscode/src/Config.ts

@@ -4,6 +4,7 @@ import { ClientProvidedConfig } from "tabby-agent";
 
 interface AdvancedSettings {
   "inlineCompletion.triggerMode"?: "automatic" | "manual";
+  "inlineCompletion.disabledLanguages"?: string[];
   "chatEdit.history"?: number;
   useVSCodeProxy?: boolean;
 }
@@ -94,6 +95,18 @@ export class Config extends EventEmitter {
     }
   }
 
+  get disabledLanguages(): string[] {
+    const advancedSettings = this.workspace.get("settings.advanced", {}) as AdvancedSettings;
+    return advancedSettings["inlineCompletion.disabledLanguages"] || [];
+  }
+
+  async updateDisabledLanguages(value: string[]) {
+    const advancedSettings = this.workspace.get("settings.advanced", {}) as AdvancedSettings;
+    advancedSettings["inlineCompletion.disabledLanguages"] = value;
+    await this.workspace.update("settings.advanced", advancedSettings, ConfigurationTarget.Global);
+    this.emit("updated");
+  }
+
   get useVSCodeProxy(): boolean {
     const advancedSettings = this.workspace.get("settings.advanced", {}) as AdvancedSettings;
     return advancedSettings["useVSCodeProxy"] ?? true;

clients/vscode/src/InlineCompletionProvider.ts

@@ -63,6 +63,13 @@ export class InlineCompletionProvider extends EventEmitter implements InlineComp
       return null;
     }
 
+    // Skip if the current language is disabled
+    const currentLanguage = document.languageId;
+    if (this.config.disabledLanguages.includes(currentLanguage)) {
+      this.logger.debug(`Skipping completion for disabled language: ${currentLanguage}`);
+      return null;
+    }
+
     // Skip when trigger automatically and text selected
     if (
       context.triggerKind === InlineCompletionTriggerKind.Automatic &&

clients/vscode/src/StatusBarItem.ts

@@ -73,6 +73,9 @@ export class StatusBarItem {
           case "ready":
           case "readyForAutoTrigger": {
             if (this.checkIfVSCodeInlineCompletionEnabled()) {
+              if (this.checkIfCurrentLanguageDisabled()) {
+                return;
+              }
               this.setColorNormal();
               this.setIcon(iconAutomatic);
               this.setTooltip(statusInfo.tooltip);
@@ -81,6 +84,9 @@ export class StatusBarItem {
           }
           case "readyForManualTrigger": {
             if (this.checkIfVSCodeInlineCompletionEnabled()) {
+              if (this.checkIfCurrentLanguageDisabled()) {
+                return;
+              }
               this.setColorNormal();
               this.setIcon(iconManual);
               this.setTooltip(statusInfo.tooltip);
@@ -106,6 +112,18 @@ export class StatusBarItem {
     }
   }
 
+  private checkIfCurrentLanguageDisabled(): boolean {
+    const currentLanguageId = window.activeTextEditor?.document.languageId;
+    const isLanguageDisabled = currentLanguageId ? this.config.disabledLanguages.includes(currentLanguageId) : false;
+    if (!isLanguageDisabled) {
+      return false;
+    }
+    this.setColorNormal();
+    this.setIcon(iconDisabled);
+    this.setTooltip(`Tabby: disabled for ${currentLanguageId} files`);
+    return true;
+  }
+
   private checkIfVSCodeInlineCompletionEnabled() {
     if (this.config.vscodeInlineSuggestEnabled) {
       return true;

clients/vscode/src/commands/commandPalette.ts

@@ -4,8 +4,6 @@ import { Client } from "../lsp/client";
 import { Config } from "../Config";
 import { isBrowser } from "../env";
 
-const MENU_ITEM_INDENT_SPACING = "      ";
-
 interface CommandPaletteItem extends QuickPickItem {
   command?: string | Command | (() => void | Promise<void>);
   picked?: boolean;
@@ -24,13 +22,7 @@ export class CommandPalette {
 
     // Status section
     const status = this.client.status.current?.status;
-    items.push(
-      {
-        label: "status",
-        kind: QuickPickItemKind.Separator,
-      },
-      this.itemForStatus(),
-    );
+    items.push(this.itemForStatus());
 
     this.client.status.on("didChange", () => {
       items[1] = this.itemForStatus();
@@ -40,23 +32,30 @@ export class CommandPalette {
     // Features section
     const validStatuses = ["ready", "readyForAutoTrigger", "readyForManualTrigger"];
     if (status !== undefined && validStatuses.includes(status)) {
-      const iconPath = this.config.inlineCompletionTriggerMode === "automatic" ? new ThemeIcon("check") : undefined;
-      const labelPrefix = iconPath ? "" : MENU_ITEM_INDENT_SPACING;
+      const isAutomatic = this.config.inlineCompletionTriggerMode === "automatic";
 
-      items.push(
-        {
-          label: "enable/disable features",
-          kind: QuickPickItemKind.Separator,
-        },
-        {
-          label: labelPrefix + "Code Completion",
-          detail: MENU_ITEM_INDENT_SPACING + "Toggle between automatic and manual completion mode",
-          picked: this.config.inlineCompletionTriggerMode === "automatic",
-          command: "tabby.toggleInlineCompletionTriggerMode",
-          iconPath: iconPath,
+      const currentLanguageId = window.activeTextEditor?.document.languageId;
+      const isLanguageDisabled = currentLanguageId ? this.config.disabledLanguages.includes(currentLanguageId) : false;
+
+      items.push({
+        label: (isAutomatic ? "Disable" : "Enable") + " completions",
+        picked: isAutomatic,
+        command: "tabby.toggleInlineCompletionTriggerMode",
+        alwaysShow: true,
+      });
+
+      if (currentLanguageId) {
+        items.push({
+          label: (isLanguageDisabled ? "Enable" : "Disable") + ` completions for ${currentLanguageId}`,
+          picked: !isLanguageDisabled,
+          command: {
+            title: "triggerLanguageInlineCompletion",
+            command: "tabby.toggleLanguageInlineCompletion",
+            arguments: [currentLanguageId],
+          },
           alwaysShow: true,
-        },
-      );
+        });
+      }
     }
 
     // Chat section
@@ -139,7 +138,7 @@ export class CommandPalette {
   }
 
   private itemForStatus(): CommandPaletteItem {
-    const STATUS_PREFIX = MENU_ITEM_INDENT_SPACING + "Status: ";
+    const STATUS_PREFIX = "Status: ";
     const languageClientState = this.client.languageClient.state;
     switch (languageClientState) {
       case LanguageClientState.Stopped:

clients/vscode/src/commands/index.ts

@@ -169,6 +169,21 @@ export class Commands {
       const commandPalette = new CommandPalette(this.client, this.config);
       commandPalette.show();
     },
+    toggleLanguageInlineCompletion: async (languageId?: string) => {
+      if (!languageId) {
+        languageId = window.activeTextEditor?.document.languageId;
+        if (!languageId) {
+          return;
+        }
+      }
+      const isLanguageDisabled = this.config.disabledLanguages.includes(languageId);
+      const disabledLanguages = this.config.disabledLanguages;
+      if (isLanguageDisabled) {
+        await this.config.updateDisabledLanguages(disabledLanguages.filter((lang) => lang !== languageId));
+      } else {
+        await this.config.updateDisabledLanguages([...disabledLanguages, languageId]);
+      }
+    },
     "outputPanel.focus": () => {
       showOutputPanel();
     },