Eslint config errors

[mAmineChniti]

this is my flat eslint config, i updated @tanstack/eslint-plugin-query from 5.71.5 to 5.72.1 and i got some linting errors on the config itself

Config

import { FlatCompat } from "@eslint/eslintrc";
import js from "@eslint/js";
import pluginQuery from "@tanstack/eslint-plugin-query";
import typescriptEslint from "@typescript-eslint/eslint-plugin";
import jsxA11yPlugin from "eslint-plugin-jsx-a11y";
import prettierPlugin from "eslint-plugin-prettier";
import reactPlugin from "eslint-plugin-react";
import reactHooksPlugin from "eslint-plugin-react-hooks";
import unicornPlugin from "eslint-plugin-unicorn";
import tseslint from "typescript-eslint";

const compat = new FlatCompat({
  baseDirectory: import.meta.dirname,
  recommendedConfig: js.configs.recommended,
  allConfig: js.configs.all,
});

export default tseslint.config(
  {
    ignores: [".next", "node_modules", ".vercel", "**/*.d.ts"],
  },
  ...compat.extends("next/core-web-vitals", "plugin:prettier/recommended"),
  {
    files: ["**/*.{ts,tsx,js,jsx,mjs,cjs}"],
    extends: [
      ...tseslint.configs.recommended,
      ...tseslint.configs.recommendedTypeChecked,
      ...tseslint.configs.stylisticTypeChecked,
    ],
    plugins: {
      "@typescript-eslint": typescriptEslint,
      react: reactPlugin,
      "react-hooks": reactHooksPlugin,
      "jsx-a11y": jsxA11yPlugin,
      unicorn: unicornPlugin,
      prettier: prettierPlugin,
     "@tanstack/query": pluginQuery, // Line 37      
    },
    rules: {
      "@typescript-eslint/array-type": "off",
      "@typescript-eslint/consistent-type-definitions": "off",
      "@typescript-eslint/consistent-type-imports": [
        "warn",
        {
          prefer: "type-imports",
          fixStyle: "inline-type-imports",
        },
      ],
      "@typescript-eslint/no-unused-vars": [
        "warn",
        {
          argsIgnorePattern: "^_",
        },
      ],
      "@typescript-eslint/require-await": "off",
      "@typescript-eslint/no-misused-promises": [
        "error",
        {
          checksVoidReturn: {
            attributes: false,
          },
        },
      ],
      "react/jsx-key": "error",
      "react/react-in-jsx-scope": "off",
      "react/prop-types": "off",
      "react-hooks/rules-of-hooks": "error",
      "react-hooks/exhaustive-deps": "warn",
      "jsx-a11y/alt-text": "warn",
      "jsx-a11y/anchor-is-valid": "warn",
      "unicorn/prevent-abbreviations": "off",
      "unicorn/consistent-function-scoping": "warn",
      "unicorn/prefer-ternary": "warn",
      "unicorn/no-null": "warn",
      "unicorn/explicit-length-check": "warn",
      "prettier/prettier": "error",
    },
    languageOptions: {
      parserOptions: {
        projectService: true,
        ecmaVersion: "latest",
        sourceType: "module",
      },
    },
    settings: {
      react: {
        version: "detect",
      },
    },
  },
  {
    linterOptions: {
      reportUnusedDisableDirectives: true,
    },
    languageOptions: {
      ecmaVersion: "latest",
      sourceType: "module",
      parserOptions: {
        projectService: true,
      },
    },
  },
  ...pluginQuery.configs["flat/recommended"], //Line 103
);

Errors

In the IDE
On Line 3 which is the import itself
Module '"node_modules/@tanstack/eslint-plugin-query/dist/index"' has no default export.ts(1192)

$ eslint . --fix
✔ No ESLint warnings or errors

eslint.config.mjs
   37:7   error  Unsafe assignment of an error typed value                @typescript-eslint/no-unsafe-assignment
  103:3   error  Unsafe spread of an error typed type                     @typescript-eslint/no-unsafe-argument
  103:18  error  Unsafe member access .configs on an `error` typed value  @typescript-eslint/no-unsafe-member-access

✖ 3 problems (3 errors, 0 warnings)

error: script "lint:fix" exited with code 1

[TkDodo]

@Newbie012 ?

[owen-vey]

@mAmineChniti you need to wait for a new release

[mAmineChniti]

oh okay thought 5.72.1 had the fix

[TkDodo]

@Newbie012 we had unrelated troubles in the monorepo that I now rolled back, but now, some eslint tasks are failing on main 😭 .

specifically:

• nx run @tanstack/query-example-react-basic:test:eslint is failing with:

> @tanstack/query-example-react-basic@ test:eslint /home/workflows/workspace/examples/react/basic
> eslint ./src


Oops! Something went wrong! :(

ESLint: 9.15.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/workflows/workspace/examples/react/basic/node_modules/@tanstack/eslint-plugin-query/build/modern/index.js' imported from /home/workflows/workspace/examples/react/basic/eslint.config.js

• nx run @tanstack/eslint-plugin-query:test:lib is failing with a test timing out

you should be able to see both errors here: https://cloud.nx.app/runs/LSFcwqaffh

I’m unsure why that is but I’d really just like to cut a release 😅

[Newbie012]

Sorry for picking this up late, I'll try to reproduce it on #8979

[Newbie012]

It was an edge case where test:eslint could be ran before ^build, which usually makes sense, but not in example projects.

[owen-vey]

Seeing the same. Almost certain it was introduced in #8925.

Edit: just tested on my end and @tanstack/eslint-plugin-query@5.71.5 did not have this issue whereas @tanstack/eslint-plugin-query@5.72.0 did