Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): date compare in shallow equal function #164

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix(react): date compare in shallow equal function #164

wants to merge 6 commits into from
+116 −0

Conversation

SashaZel
Copy link

@SashaZel SashaZel commented Feb 4, 2025

Fix #160

@crutchcorn
Copy link
Member

Nice! This is a great fix. Can we apply the same fix to the other frameworks with similar shallow methods?

@nikolovlazar nikolovlazar mentioned this pull request Feb 22, 2025
Open
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 8, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 4fb8437.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 49s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-08 01:23:33 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 8, 2025

@tanstack/angular-store

npm i https://pkg.pr.new/@tanstack/angular-store@164

@tanstack/react-store

npm i https://pkg.pr.new/@tanstack/react-store@164

@tanstack/store

npm i https://pkg.pr.new/@tanstack/store@164

@tanstack/solid-store

npm i https://pkg.pr.new/@tanstack/solid-store@164

@tanstack/svelte-store

npm i https://pkg.pr.new/@tanstack/svelte-store@164

@tanstack/vue-store

npm i https://pkg.pr.new/@tanstack/vue-store@164

commit: 4fb8437

@SashaZel
Copy link
Author

Nice! This is a great fix. Can we apply the same fix to the other frameworks with similar shallow methods?

Hi,
Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date store not synced properly when using a selector
3 participants
@SashaZel @crutchcorn @lachlancollins