-
-
Notifications
You must be signed in to change notification settings - Fork 341
Scrolling does not work correctly. #960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can't fork the CodeSandbox due to:
The main issue is that in a scrolling container with a sticky header, the virtualizer needs to account for it. This can be handled using scrollMargin. The trick is that since the margin is applied to items, we need to subtract it from the top during rendering using:
Additionally, because the header is sticky, we need to inform the virtualizer by setting scrollPaddingStart.
With these adjustments, everything should align properly. |
Thank you. I did as you wrote (updated the example) and it works. But only if there is no horizontal scrolling. I tried increasing the scrollMargin and scrollPaddingStart, but it didn't solve the problem. How would you also take into account the amount of scrolling? |
hmm don't sound right, horizontal scrolling should not affect it, hard to say without example. |
An example with the added parameters is here |
Works fine for me, don't really follow what's the issue, maybe you want to useWindowVirtualizer? |
Closing this now. If any new issues arise, feel free to reopen or create a new issue. |
@alkosorukov apologies for closing the issue earlier. At the time, I wasn't able to reproduce it. However, now i see that the bug is visible when scrollbars are present. |
@piecyk any update on this issue as i'm also facing the same in safari |
Describe the bug
Scrolling does not work correctly. I thought the problem was with the position: sticky table header, but no.
Your minimal, reproducible example
https://codesandbox.io/p/devbox/mystifying-dew-t5nd7v?workspaceId=ws_G2EwNr8rBvsbnPfjfHKzRb
Steps to reproduce
Let's take a basic example from https://tanstack.com/table/v8/docs/framework/react/examples/virtualized-rows and add a button (for example, scroll to the last element).
Expected behavior
We expect: when you click on the button, you will see 50,000 items. Reality: we not see element 50000.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
windows, edge
tanstack-virtual version
3.13.14
TypeScript version
No response
Additional context
No response
Terms & Code of Conduct
The text was updated successfully, but these errors were encountered: