You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/07_release_instructions.md
+16-14Lines changed: 16 additions & 14 deletions
Original file line number
Diff line number
Diff line change
@@ -1,6 +1,6 @@
1
1
# Release instructions for normal releases
2
2
3
-
This page just contains detailed instructions for normal releases. Refer to [Releasing](../06_releasing) for other information about releases.
3
+
This page contains detailed instructions for normal releases. Refer to [Releasing](../06_releasing) for other information about releases.
4
4
5
5
## Preliminary steps
6
6
@@ -23,7 +23,7 @@ This page just contains detailed instructions for normal releases. Refer to [Rel
23
23
24
24
### Version name and conventions
25
25
26
-
- Find the version code of the next release by looking for `versionCode` in [`app/build.gradle`](https://github.com/TeamNewPipe/NewPipe/blob/dev/app/build.gradle): 1 added to that value (from now on called `NEW_VERSION_CODE`) will be the new value (but do not edit the file yet)
26
+
- Find the version code of the next release by looking for `versionCode` in [`app/build.gradle`](https://github.com/TeamNewPipe/NewPipe/blob/dev/app/build.gradle): You will add 1 to that value (from now on called `NEW_VERSION_CODE`) to get the new value (but do not edit the file yet)
27
27
- Choose the version number of the next release according to [semantic versioning](https://semver.org/) (from now on called `X.X.X`)
28
28
29
29
### Identification
@@ -36,7 +36,7 @@ This page just contains detailed instructions for normal releases. Refer to [Rel
36
36
- Go to [Weblate's Maintenance tab](https://hosted.weblate.org/projects/newpipe/#repository)
37
37
- Press the *Lock* button to prevent translators from translating while you are creating commits; remember to *Unlock* later!
38
38
- Press the *Update* button to update Weblate with the latest changes on NewPipe's `dev` branch
39
-
- Press the *Commit* button, if needed, to make sure Weblate creates a commit for translations which had not been committed yet
39
+
- Press the *Commit* button, if needed, to make sure Weblate creates a commit for translations which have not been committed yet
40
40
- Now go back to the local git repository
41
41
- In case you followed these steps before, delete the `weblate-dev` branch
42
42
-`git branch -D weblate-dev`
@@ -116,7 +116,7 @@ Now there should be two new commits (the Weblate and changelog ones) on your loc
116
116
## Creating the Pull Request
117
117
118
118
- Create a Pull Request (PR) from the new branch you just pushed
119
-
- If you used the correct branch name you should be able to use this url, after changing the X.X.X: https://github.com/TeamNewPipe/NewPipe/pull/new/release-X.X.X
119
+
- If you used the correct branch name you should be able to use this URL, after changing the X.X.X: https://github.com/TeamNewPipe/NewPipe/pull/new/release-X.X.X
120
120
- Make sure the PR has `master` as the *base* branch and `release-X.X.X` as the *compare* branch
121
121
- The PR title should be "Release vX.X.X (NEW_VERSION_CODE)"
122
122
- Remove the entire PR template, and instead put these two lines in the description (the `ISSUE_NUMBER` will be replaced later):
@@ -126,7 +126,7 @@ Now there should be two new commits (the Weblate and changelog ones) on your loc
126
126
```
127
127
- Once you have created the PR, note down its number (from now on called `PR_NUMBER`)
128
128
- In case some issue would be fixed when the release PR is merged, link them using the "Development" tab on the right, or add a "Fixes #...." in the PR description
129
-
- *for example, check out [#8231](https://github.com/TeamNewPipe/NewPipe/pull/8231) for reference*
129
+
- *Check out [#8231](https://github.com/TeamNewPipe/NewPipe/pull/8231) for reference*
130
130
131
131
## Creating the issue
132
132
@@ -143,12 +143,12 @@ Now there should be two new commits (the Weblate and changelog ones) on your loc
143
143
- The `## NewPipeExtractor version` should contain a link to the NewPipeExtractor release this new NewPipe version will ship with (i.e. the one set in [Creating the release branch](#creating-the-release-branch))
144
144
- Copy the draft Markdown changelog [kept on GitHub](https://github.com/TeamNewPipe/NewPipe/releases) (you finalized it earlier in [Create a changelog](#create-a-changelog)) to the clipboard and paste it under the `## App changelog` section
145
145
- Once you have created the issue, pin it using the "Pin issue" button on the right
146
-
- *for example, check out [#8230](https://github.com/TeamNewPipe/NewPipe/issues/8230) for reference*
146
+
- *Check out [#8230](https://github.com/TeamNewPipe/NewPipe/issues/8230) for reference*
147
147
148
148
## Testing APKs
149
149
150
150
The first time you open the release issue, and then each time some changes are made to the release PR, you should provide a debug APK in the `## Testing for regressions` section.
151
-
- Wait for the Continuous Integration (CI) to finish testing the PR, then download the debug APK it will have built from the "Checks" tab
151
+
- Wait for the Continuous Integration (CI) to finish testing the PR, then download the resulting debug APK artifact from the "Checks" tab
152
152
- Rename it to `NewPipe_vX.X.X_RC1_debug.apk` where `RC1` should be incremented to `RC2` and so on each time a new APK is provided
153
153
- Zip it and make sure the `.zip` file has the same name as the `.apk` it contains
154
154
- Upload it in the issue description, replacing the `...` placeholder used above
@@ -162,7 +162,7 @@ Sometimes it might be needed to also provide a release APK. In this case follow
162
162
163
163
## Taking care of regressions (quickfixes)
164
164
165
-
The release issue and pull request should stay open for **roughly one week**, so that people can test the provided APKs and give feedback. If a *regression* is reported by some user, it should possibly be solved before releasing, otherwise the app would become more broken after each release. A *regression* is a bug now present in some code that used to run well in the last release, but was then modified in this release (supposedly to fix something else) and is now broken. So the following do not classify as regressions: some videos stop working because YouTube made some changes; the newly introduced big feature XYZ is still not perfect and has some bugs; a random crash reproducible also on previous versions... You get the point. Before releasing, try to fix any regression that come out, but avoid fixing non-regressions, since those should be treated with the same care and attention as all other issues. Maintainers have to be aware that they might be required to fix regressions, so plan your release at a time when you are available.
165
+
The release issue and pull request should stay open for **roughly one week**, so that people can test the provided APKs and give feedback. If a *regression* is reported by some user, it should possibly be solved before releasing, otherwise the app would become more broken after each release. A *regression* is a bug now present in some code that used to run well in the last release, but was then modified in this release (supposedly to fix something else) and is now broken. So the following do not classify as regressions: some videos stop working because YouTube made some changes; the newly introduced big feature XYZ is still not perfect and has some bugs; a random crash reproducible also on previous versions... You get the point. Before releasing, try to fix any regressions that are reported, but avoid fixing non-regressions, since those should be treated with the same care and attention as all other issues. As a Release Manager, you might be required to fix regressions, so plan your release at a time when you are available.
166
166
167
167
Pull requests fixing regressions should target the `release-X.X.X` branch, not the `dev` branch! When merging those PRs, also provide a new Release Candidate APK.
168
168
@@ -207,7 +207,7 @@ Now on the remote `master` branch there is the release code which you need to tu
207
207
- `git checkout master`
208
208
- `git pull origin master`
209
209
- Open the local project in Android Studio
210
-
- Run the Gradle `clean` task using Android Studio's interface, in order to cleanup temporary/cache files that may interfere with reproducible builds
210
+
- Run the Gradle `clean` task using Android Studio's interface, in order to clean up temporary/cache files that may interfere with reproducible builds
211
211
- Double press Ctrl, type `gradle clean`, press Enter
212
212
- Make sure leftover files from building RC releases are actually removed, in order to avoid confusion
213
213
- `rm -rf ./app/release`
@@ -217,15 +217,15 @@ Now on the remote `master` branch there is the release code which you need to tu
217
217
218
218
## Having the APK signed by @TheAssassin
219
219
220
-
Currently @TheAssassin is the only holder of NewPipe's APK signing keys. Therefore you should send the unsigned APK to him and he will send a signed one back. He will also then publish the signed APK in NewPipe's F-Droid repo.
220
+
Currently @TheAssassin is the only holder of NewPipe's APK signing keys. Therefore you should send the unsigned APK to him, after which he will sign it and send it back to you. He will also then publish the signed APK in NewPipe's F-Droid repo.
221
221
- Rename `app-release-unsigned.apk` to `NewPipe_vX.X.X.apk`
222
222
- Generate a signature for the APK file
223
223
- `gpg -b NewPipe_vX.X.X.apk` will generate `NewPipe_vX.X.X.apk.sig`
224
224
- It will also output 'using "FINGERPRINT" as default secret key for signing'; keep track of the `FINGERPRINT` part
225
225
- Send an email to @TheAssassin and attach both `NewPipe_vX.X.X.apk` and `NewPipe_vX.X.X.apk.sig`
226
226
- If @TheAssassin does not already know it, send him your PGP key `FINGERPRINT` you obtained before
227
-
- You should send it not using email this time, but another service on which @TheAssassin can be almost sure it is really you (something like 2FA)
228
-
- For example, either just send it on the IRC group, or create a GitHub gist with the fingerprint and then give that link to @TheAssassin
227
+
- You should not send it using email this time, but using another service through which @TheAssassin can be almost sure it is really you (this is a sort of 2FA)
228
+
- For example, you can send it on the IRC group, or create a GitHub gist with the fingerprint and then give that link to @TheAssassin
229
229
- Notify him on IRC that you have sent him an email
230
230
- He will send you back the signed APK
231
231
- Make sure its name is still `NewPipe_vX.X.X.apk` (rename if it's not the case)
@@ -244,10 +244,12 @@ Currently @TheAssassin is the only holder of NewPipe's APK signing keys. Therefo
244
244
245
245
## Blog post
246
246
247
-
> I do not know enough about blog post writing and publishing to fill in this section, I'll leave it to @opusforlife2 and @Poolitzer.
247
+
The blog post writers need an up-to-date list of merged PRs numbered in chronological order. This is so that they can keep track of what changes have already been detailed in the draft blog post, and which ones still need to be added. So make sure that there is always at least one up-to-date "master copy" of the draft release notes available for them to review.
248
+
249
+
The blog post should ideally be published before the GitHub release is made (so that the link to it works!), but in case of some delay, it is fine to let the blog post come later. It is far more important to get the release into users' hands sooner.
248
250
249
251
- In order for the blog post to be published, ask @TheAssassin to "press the buttons" again
250
-
- Once the blog post is ready (which, in optimal cases, should happen before the release is published, but that's not a must), add this block of text on top of the release notes on GitHub:
252
+
- Once the blog post is ready, add this block of text on top of the release notes on GitHub:
251
253
```
252
254
[:arrow_right: :arrow_right: :arrow_right: Read the blog post :arrow_left: :arrow_left: :arrow_left:](LINK_TO_BLOG_POST)
0 commit comments