fix: deprecation warnings (nozaq#140)

Author: willfarrell

bucket.tf

@@ -116,7 +116,7 @@ data "aws_iam_policy_document" "audit_log" {
     actions = ["s3:*"]
     effect  = "Deny"
     resources = [
-      "${module.audit_log_bucket.this_bucket.arn}",
+      module.audit_log_bucket.this_bucket.arn,
       "${module.audit_log_bucket.this_bucket.arn}/*"
     ]
     condition {

modules/cloudtrail-baseline/main.tf

@@ -119,7 +119,7 @@ data "aws_iam_policy_document" "cloudtrail_key_policy" {
     condition {
       test     = "StringEquals"
       variable = "kms:CallerAccount"
-      values   = ["${var.aws_account_id}"]
+      values   = [var.aws_account_id]
     }
     condition {
       test     = "StringLike"
@@ -144,7 +144,7 @@ data "aws_iam_policy_document" "cloudtrail_key_policy" {
     condition {
       test     = "StringEquals"
       variable = "kms:CallerAccount"
-      values   = ["${var.aws_account_id}"]
+      values   = [var.aws_account_id]
     }
   }
 
@@ -162,7 +162,7 @@ data "aws_iam_policy_document" "cloudtrail_key_policy" {
     condition {
       test     = "StringEquals"
       variable = "kms:CallerAccount"
-      values   = ["${var.aws_account_id}"]
+      values   = [var.aws_account_id]
     }
     condition {
       test     = "StringLike"

modules/secure-bucket/main.tf

@@ -5,7 +5,7 @@ data "aws_iam_policy_document" "access_log_policy" {
     actions = ["s3:*"]
     effect  = "Deny"
     resources = [
-      "${aws_s3_bucket.access_log[0].arn}",
+      aws_s3_bucket.access_log[0].arn,
       "${aws_s3_bucket.access_log[0].arn}/*"
     ]
     condition {