Skip to content
This repository was archived by the owner on Mar 6, 2025. It is now read-only.

Commit eae0a7d

Browse files
Merge pull request #132 from Ultimaker/naviagtion-improvements
Navigation component changes
2 parents 1d6dce8 + 66fa678 commit eae0a7d

File tree

1 file changed

+49
-53
lines changed

1 file changed

+49
-53
lines changed

src/components/navigation.tsx

Lines changed: 49 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -59,63 +59,59 @@ export default class Navigation extends React.Component<NavigationProps, Navigat
5959

6060
return (
6161
<nav className={navClasses} role="navigation">
62+
<div className="nav-links-container">
63+
<div className="burger-menu hide-sm">
64+
<Button
65+
appearance="primary"
66+
shape="circle"
67+
onClickHandler={() => this._toggleShowNav(!showNav)}
68+
>
69+
<div className={burgerIconClasses} />
70+
</Button>
71+
</div>
6272

63-
{visibleNavLinks.length > 0 && (
64-
<div className="nav-links-container">
65-
<div className="burger-menu hide-sm">
66-
<Button
67-
appearance="primary"
68-
shape="circle"
69-
onClickHandler={() => this._toggleShowNav(!showNav)}
70-
>
71-
<div className={burgerIconClasses} />
72-
</Button>
73-
</div>
74-
75-
<Motion style={{ x: spring(showNav ? 56 : 0, motion) }}>
76-
{({ x }) => (
77-
<ul>
78-
{visibleNavLinks.map((navLink, index) => (
79-
<li key={navLink.path} style={{ top: `${(index + 1) * x}px` }}>
80-
<NavLink
81-
to={navLink.path}
82-
activeClassName="active"
83-
className="nav-link"
84-
onClick={() => this._toggleShowNav(false)}
85-
>
86-
<span className="label">{navLink.label}</span>
87-
</NavLink>
88-
</li>
89-
))}
90-
91-
{manageAccountURL && (
92-
<li style={{ top: `${(visibleNavLinks.length + 1) * x}px` }} className="hide-sm">
93-
<a href={manageAccountURL} className="nav-link" target="_blank" rel="noopener noreferrer">
94-
<span className="label">{I18n.translate('Nav manage account button', 'Account')}</span>
95-
</a>
96-
</li>
97-
)}
98-
99-
{onSignOutClickHandler && (
100-
<li style={{ top: `${(visibleNavLinks.length + (manageAccountURL ? 2 : 1)) * x}px` }} className="hide-sm">
101-
<Button className="nav-link" onClickHandler={onSignOutClickHandler} appearance="no-style">
102-
<span className="label">{I18n.translate('Nav sign out button', 'Sign out')}</span>
103-
</Button>
104-
</li>
105-
)}
106-
</ul>
107-
)}
108-
</Motion>
109-
110-
{children && (
111-
<div className="children-containter">
112-
{children}
113-
</div>
73+
<Motion style={{ x: spring(showNav ? 56 : 0, motion) }}>
74+
{({ x }) => (
75+
<ul>
76+
{visibleNavLinks.map((navLink, index) => (
77+
<li key={navLink.path} style={{ top: `${(index + 1) * x}px` }}>
78+
<NavLink
79+
to={navLink.path}
80+
activeClassName="active"
81+
className="nav-link"
82+
onClick={() => this._toggleShowNav(false)}
83+
>
84+
<span className="label">{navLink.label}</span>
85+
</NavLink>
86+
</li>
87+
))}
88+
89+
{manageAccountURL && (
90+
<li style={{ top: `${(visibleNavLinks.length + 1) * x}px` }} className="hide-sm">
91+
<a href={manageAccountURL} className="nav-link" target="_blank" rel="noopener noreferrer">
92+
<span className="label">{I18n.translate('Nav manage account button', 'Account')}</span>
93+
</a>
94+
</li>
95+
)}
96+
97+
{onSignOutClickHandler && (
98+
<li style={{ top: `${(visibleNavLinks.length + (manageAccountURL ? 2 : 1)) * x}px` }} className="hide-sm">
99+
<Button className="nav-link" onClickHandler={onSignOutClickHandler} appearance="no-style">
100+
<span className="label">{I18n.translate('Nav sign out button', 'Sign out')}</span>
101+
</Button>
102+
</li>
103+
)}
104+
</ul>
114105
)}
106+
</Motion>
115107

116-
</div>
117-
)}
108+
{children && (
109+
<div className="children-containter">
110+
{children}
111+
</div>
112+
)}
118113

114+
</div>
119115
</nav>
120116
);
121117
}

0 commit comments

Comments
 (0)