FIX: Remoting code producing invalid pointers on 32bit Android (#1240).

Author: todi1856

Assets/Tests/InputSystem/CoreTests_Remoting.cs

@@ -118,9 +118,6 @@ public void Remote_OnlyGeneratedLayoutsAreSentToRemotes()
 
     [Test]
     [Category("Remote")]
-#if UNITY_ANDROID && !UNITY_EDITOR
-    [Ignore("Case 1254567")]
-#endif
     public void Remote_EventsAreSentToRemotes()
     {
         var gamepad = InputSystem.AddDevice<Gamepad>();

Packages/com.unity.inputsystem/InputSystem/Devices/Remote/InputRemoting.cs

@@ -624,8 +624,9 @@ public static unsafe void Process(InputRemoting receiver, Message msg)
                     var eventCount = 0;
                     var eventPtr = new InputEventPtr((InputEvent*)dataPtr);
                     var senderIndex = receiver.FindOrCreateSenderRecord(msg.participantId);
-
-                    while ((Int64)eventPtr.data < dataEndPtr.ToInt64())
+                    // Don't use IntPtr.ToInt64() function, on 32 bit systems, the pointer is first converted to Int32 and then casted to Int64
+                    // Thus for big pointer value, you might get a negative value even though the pointer value will be less than Int64.MaxValue
+                    while ((void*)eventPtr.data < dataEndPtr.ToPointer())
                     {
                         // Patch up device ID to refer to local device and send event.
                         var remoteDeviceId = eventPtr.deviceId;

Packages/com.unity.inputsystem/InputSystem/InputSystem.cs

@@ -2900,8 +2900,11 @@ private static void SetUpRemotingInternal()
         #if !UNITY_EDITOR
         private static bool ShouldEnableRemoting()
         {
-            ////FIXME: is there a better way to detect whether we are running tests?
-            var isRunningTests = Application.productName == "UnityTestFramework";
+#if UNITY_INCLUDE_TESTS
+            var isRunningTests = true;
+#else
+            var isRunningTests = false;
+#endif
             if (isRunningTests)
                 return false; // Don't remote while running tests.
             return true;