Skip to content

disable hysteria brutal algo? #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VendettaReborn opened this issue Feb 14, 2025 · 7 comments
Open

disable hysteria brutal algo? #716

VendettaReborn opened this issue Feb 14, 2025 · 7 comments

Comments

@VendettaReborn
Copy link
Contributor

context

XTLS/Xray-core#3547

key

"大家能一起换到 BBR、一起提升体验,而大家一起 Brutal 就会炸。Brutal 并不是传统的拥塞控制,本质上是抢占带宽"

thoughts

shall we disable hysteria Brutal algorithm by some feature gate, or just delete the Brutal part of the code?

@Itsusinn
Copy link
Member

Client's Congestion Controller doesn't affect too much to the Network, because it only affects uplink bandwidth

@VendettaReborn
Copy link
Contributor Author

more contexts: 可恶的 TCP 加速

@VendettaReborn
Copy link
Contributor Author

VendettaReborn commented Feb 14, 2025

i think the point is, if we think brutal is bad(to me, that's a fact), should we hand the option to clash-rs's users?

@Itsusinn
Copy link
Member

more contexts: 可恶的 TCP 加速

In that theory, BBR is just as bad as Brutal (

@VendettaReborn
Copy link
Contributor Author

maybe, but the main purpose of this issue is to raise the discussion. better to remain a debate than integrating the BBR/Brutal into project without considering this moral concerns.

@ibigbug
Copy link
Member

ibigbug commented Feb 15, 2025

There's successful examples using BBR for broader internet https://aws.amazon.com/blogs/networking-and-content-delivery/tcp-bbr-congestion-control-with-amazon-cloudfront/

BBR responds more agilely to changing conditions, but continues to aggressively attempt to transmit as much data as possible even when there are transient issues.

I'm not sure if Brutal does slow down in the case condition gets worse, it seems BBR does that in certain case?

@ibigbug
Copy link
Member

ibigbug commented Feb 15, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants