Skip to content

[C API] Some BinaryenString* functions declared in binaryen-c.h without implementation #7301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leobuskin opened this issue Feb 19, 2025 · 3 comments

Comments

@leobuskin
Copy link

leobuskin commented Feb 19, 2025

  • BinaryenStringIterNext
  • BinaryenStringIterMove
  • BinaryenStringSliceIter
  • BinaryenStringNewSetTry
  • BinaryenStringWTF8Advance

My FFI tooling breaks on those. Looks like there's no implementation, just declaration. Am I missing some compilation flags?

I've tried to find related commits (in case they were removed), but GitHub search wasn't helpful

@kripken
Copy link
Member

kripken commented Feb 21, 2025

Those do appear to be missing implementations. Declarations were added in 0821cd1 but I guess those were forgotten. It would be good to add them now if someone has time.

@GulgDev
Copy link
Contributor

GulgDev commented Apr 14, 2025

Implementations of BinaryenStringIterNext, BinaryenStringIterMove, and BinaryenStringSliceIter were added in 0821cd1, but for some reason they were later removed.

@kripken
Copy link
Member

kripken commented Apr 15, 2025

These would be good to add, but note that we now have a StringLifting pass. One can emit imported strings, then lift them into the String* instructions, so it is less important to emit String* instructions directly (in fact, most toolchains might prefer not to, since VMs don't support them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants