Skip to content

Commit 39ed4e2

Browse files
authored
Merge pull request #29 from mitchcapper/event_listener_for_events
Use addEventListener with proper delegates for any events rather than inline javascript/setAttribute("on*")
2 parents 45a5849 + 3e2da4f commit 39ed4e2

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

code-input.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,8 +159,8 @@ var codeInput = {
159159
textarea.setAttribute("name", this.getAttribute("name")); // for use in forms
160160
}
161161

162-
textarea.setAttribute("oninput", "this.parentElement.update(this.value); this.parentElement.sync_scroll();");
163-
textarea.setAttribute("onscroll", "this.parentElement.sync_scroll();");
162+
textarea.addEventListener('input',(evt) => { textarea.parentElement.update(textarea.value); textarea.parentElement.sync_scroll();});
163+
textarea.addEventListener('scroll',(evt) => textarea.parentElement.sync_scroll());
164164
this.append(textarea);
165165

166166
/* Create pre code */

plugins/indent.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
afterElementsAdded(codeInput) {
1313
codeInput.check_tab = this.check_tab;
1414
codeInput.check_enter = this.check_enter;
15-
codeInput.querySelector("textarea").setAttribute("onkeydown", "this.parentElement.check_tab(event); this.parentElement.check_enter(event);");
15+
let textarea = codeInput.querySelector("textarea");
16+
textarea.addEventListener('keydown',(event) => { textarea.parentElement.check_tab(event); textarea.parentElement.check_enter(event)});
1617
}
1718

1819
/* Event handlers */

0 commit comments

Comments
 (0)