fix bad ternary precedence

keithamus · keithamus · commit 8efe8355c1b9 · 2022-12-25T16:55:14.000Z
diff --git a/script/tag-name-input.js b/script/tag-name-input.js
@@ -32,7 +32,8 @@ customElements.define('tag-name-input', class extends HTMLInputElement {
       }
     }
     this.reportValidity()
-    this.parentElement.querySelector('.error').textContent = this.validationMessage || value ? 'Valid custom element name!' : ''
+    const errorEl = this.parentElement.querySelector('.error')
+    errorEl.textContent = this.validationMessage || (value ? 'Valid custom element name!' : '')
   }
 
 }, { extends: 'input' })

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,8 @@ customElements.define('tag-name-input', class extends HTMLInputElement {`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`	`this.reportValidity()`
`35`		`- this.parentElement.querySelector('.error').textContent = this.validationMessage \|\| value ? 'Valid custom element name!' : ''`
	`35`	`+ const errorEl = this.parentElement.querySelector('.error')`
	`36`	`+ errorEl.textContent = this.validationMessage \|\| (value ? 'Valid custom element name!' : '')`
`36`	`37`	`}`
`37`	`38`
`38`	`39`	`}, { extends: 'input' })`