Fix ExpectedConditions.not to use equals for Boolean comparisions to fix a bug where new Boolean(false) was not considered to equal to false

Signed-off-by: Simon Stewart <[email protected]>

Author: Mikko Tiihonen

java/client/src/org/openqa/selenium/support/ui/ExpectedConditions.java

@@ -859,7 +859,7 @@ public static ExpectedCondition<Boolean> not(final ExpectedCondition<?> conditio
       @Override
       public Boolean apply(WebDriver driver) {
         Object result = condition.apply(driver);
-        return result == null || result == Boolean.FALSE;
+        return result == null || result.equals(Boolean.FALSE);
       }
 
       @Override

java/client/test/org/openqa/selenium/support/ui/ExpectedConditionsTest.java

@@ -234,7 +234,7 @@ public void waitingForVisibilityOfElementInverse_elementStaysVisible()
 
   @Test
   public void invertingAConditionThatReturnsFalse() {
-    when(mockCondition.apply(mockDriver)).thenReturn(false);
+    when(mockCondition.apply(mockDriver)).thenReturn(new Boolean(false));
 
     assertTrue(wait.until(not(mockCondition)));
     verifyZeroInteractions(mockSleeper);
@@ -252,7 +252,7 @@ public void invertingAConditionThatReturnsNull() {
   public void invertingAConditionThatAlwaysReturnsTrueTimesout() throws InterruptedException {
     when(mockClock.laterBy(1000L)).thenReturn(3000L);
     when(mockClock.isNowBefore(3000L)).thenReturn(true, false);
-    when(mockCondition.apply(mockDriver)).thenReturn(true);
+    when(mockCondition.apply(mockDriver)).thenReturn(new Boolean(true));
 
     try {
       wait.until(not(mockCondition));