-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
title-based scoping methods on Course are not wiki-specific #6252
Comments
working on this |
@Formasitchijoh you still working on it? Let me know if you need any assistance |
@ragesoss just wish to confirm something Can a course in the ArticleScopedProgram have more than one wiki ie contains articles from different wiki |
@Formasitchijoh yes, but the records that provide the titles (Category records and Assignment records) for it are wiki-specific. |
Okay so could it mean we need to check if the wiki of title (Category records and Assignment records) is found in the Course wikis, because, I realized we don't check that yet |
The method gets used in the update service, when processing revisions from one of the course's wikis at at time. So the idea would be, change the method to take a wiki as the argument, and only return titles for that wiki. |
We use
#scoped_article_titles
to filter revision when processing ArticleScopedPrograms, but the method is not wiki-specific, so can include titles across multiple wikis and will incorrectly treat an article on one wiki as in-scope even if it was only assigned (or present in a category) on another wiki.The text was updated successfully, but these errors were encountered: