Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

title-based scoping methods on Course are not wiki-specific #6252

Open
ragesoss opened this issue Mar 11, 2025 · 7 comments
Open

title-based scoping methods on Course are not wiki-specific #6252

ragesoss opened this issue Mar 11, 2025 · 7 comments
Labels

Comments

@ragesoss
Copy link
Member

We use #scoped_article_titles to filter revision when processing ArticleScopedPrograms, but the method is not wiki-specific, so can include titles across multiple wikis and will incorrectly treat an article on one wiki as in-scope even if it was only assigned (or present in a category) on another wiki.

@ragesoss ragesoss added the bug label Mar 11, 2025
@Formasitchijoh
Copy link
Contributor

working on this

@lupamo
Copy link
Contributor

lupamo commented Mar 30, 2025

@Formasitchijoh you still working on it? Let me know if you need any assistance

@Formasitchijoh
Copy link
Contributor

@ragesoss just wish to confirm something

Can a course in the ArticleScopedProgram have more than one wiki ie contains articles from different wiki

@ragesoss
Copy link
Member Author

@Formasitchijoh yes, but the records that provide the titles (Category records and Assignment records) for it are wiki-specific.

@Formasitchijoh
Copy link
Contributor

Okay so could it mean we need to check if the wiki of title (Category records and Assignment records) is found in the Course wikis, because, I realized we don't check that yet

@ragesoss
Copy link
Member Author

The method gets used in the update service, when processing revisions from one of the course's wikis at at time. So the idea would be, change the method to take a wiki as the argument, and only return titles for that wiki.

@Formasitchijoh
Copy link
Contributor

I realized you updated the #scoped_article_titles method to take the specific wiki as an argument, but I can't find the update service you were referring to, still testing to see if the issue is still occurring

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants