Improve name of WP file-not-found action callback

Author: brandonpayton

packages/php-wasm/node/src/test/php-request-handler.spec.ts

@@ -1,6 +1,6 @@
 import { RecommendedPHPVersion } from '@wp-playground/common';
 // eslint-disable-next-line @nx/enforce-module-boundaries -- ignore test-related interdependencies so we can test.
-import { defaultWordPressFileNotFoundActionCallBack } from '@wp-playground/wordpress';
+import { getFileNotFoundActionForWordPress } from '@wp-playground/wordpress';
 import { loadNodeRuntime } from '..';
 import {
 	FileNotFoundGetActionCallback,
@@ -427,8 +427,7 @@ describe.each(SupportedPHPVersions)(
 
 		describe('WordPress requests', () => {
 			beforeEach(() => {
-				getFileNotFoundActionTest =
-					defaultWordPressFileNotFoundActionCallBack;
+				getFileNotFoundActionTest = getFileNotFoundActionForWordPress;
 			});
 			it('should delegate request for non-existent PHP file to /index.php with query args', async () => {
 				php.writeFile(

packages/playground/remote/src/lib/worker-thread.ts

@@ -38,7 +38,7 @@ import playgroundWebMuPlugin from './playground-mu-plugin/0-playground.php?raw';
 import { PHPResponse, PHPWorker } from '@php-wasm/universal';
 import {
 	bootWordPress,
-	defaultWordPressFileNotFoundActionCallBack,
+	getFileNotFoundActionForWordPress,
 	getLoadedWordPressVersion,
 } from '@wp-playground/wordpress';
 import { wpVersionToStaticAssetsDirectory } from '@wp-playground/wordpress-builds';
@@ -266,7 +266,7 @@ try {
 					),
 				};
 			} else {
-				return defaultWordPressFileNotFoundActionCallBack(relativeUri);
+				return getFileNotFoundActionForWordPress(relativeUri);
 			}
 		},
 	});

packages/playground/wordpress/src/boot.ts

@@ -178,8 +178,7 @@ export async function bootWordPress(options: BootOptions) {
 		absoluteUrl: options.siteUrl,
 		rewriteRules: wordPressRewriteRules,
 		getFileNotFoundAction:
-			options.getFileNotFoundAction ??
-			defaultWordPressFileNotFoundActionCallBack,
+			options.getFileNotFoundAction ?? getFileNotFoundActionForWordPress,
 	});
 
 	const php = await requestHandler.getPrimaryPhp();
@@ -268,7 +267,7 @@ async function installWordPress(php: PHP) {
 	);
 }
 
-export function defaultWordPressFileNotFoundActionCallBack(
+export function getFileNotFoundActionForWordPress(
 	// eslint-disable-next-line @typescript-eslint/no-unused-vars -- maintain consistent FileNotFoundGetActionCallback signature
 	relativeUri: string
 ): FileNotFoundAction {

packages/playground/wordpress/src/index.ts

@@ -1,10 +1,7 @@
 import { PHP, UniversalPHP } from '@php-wasm/universal';
 import { joinPaths, phpVar } from '@php-wasm/util';
 import { unzipFile } from '@wp-playground/common';
-export {
-	bootWordPress,
-	defaultWordPressFileNotFoundActionCallBack,
-} from './boot';
+export { bootWordPress, getFileNotFoundActionForWordPress } from './boot';
 export {
 	getLoadedWordPressVersion,
 	isSupportedWordPressVersion,