Skip to content

Commit ef9cb10

Browse files
committed
remove: updateChecker in shared options
1 parent bfb6188 commit ef9cb10

File tree

6 files changed

+5
-18
lines changed

6 files changed

+5
-18
lines changed

babel-plugin-code-push/index.js

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ const OPTIONS_TO_BUNDLE = [
66
"bundleHost",
77
"runtimeVersion",
88
"versioning",
9-
"updateChecker",
109
];
1110

1211
module.exports = function (babel, options) {

babel-plugin-code-push/test/cases/test1-config

-3
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,4 @@ module.exports = {
1212
bundleHost: "bundleHost",
1313
runtimeVersion: "runtimeVersion",
1414
versioning: CustomVersioning,
15-
updateChecker: (updateRequest) => {
16-
// ..my Implementation
17-
},
1815
};

babel-plugin-code-push/test/cases/test1-output

-3
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,5 @@ codePush({
77
constructor() {
88
super();
99
}
10-
},
11-
updateChecker: updateRequest => {
12-
// ..my Implementation
1310
}
1411
});

babel-plugin-code-push/test/cases/test2-config

-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,4 @@ module.exports = {
66
bundleHost: "bundleHost",
77
runtimeVersion: "runtimeVersion",
88
versioning: SemverVersioning,
9-
updateChecker: (updateRequest) => {
10-
// ..my Implementation
11-
},
129
};

babel-plugin-code-push/test/cases/test2-output

+1-4
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,5 @@ import codePush from "@bravemobile/react-native-code-push";
33
codePush({
44
bundleHost: "bundleHost",
55
runtimeVersion: "runtimeVersion",
6-
versioning: SemverVersioning,
7-
updateChecker: updateRequest => {
8-
// ..my Implementation
9-
}
6+
versioning: SemverVersioning
107
});

typings/react-native-code-push.d.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,6 @@ interface CodePushSharedOptions {
7979
* Defaults to `SemverVersioning`
8080
*/
8181
versioning?: typeof BaseVersioning;
82-
/**
83-
* Specifies a function to get the release history.
84-
*/
85-
updateChecker: (updateRequest: UpdateCheckRequest) => Promise<ReleaseHistoryInterface>;
8682
}
8783

8884
export interface CodePushConfigFile extends CodePushSharedOptions {
@@ -100,6 +96,10 @@ export interface CodePushOptions extends CodePushSharedOptions, SyncOptions {
10096
* Specifies whether to run the original action, which queries AppCenter if an error occurs while running the `updateChecker` function.
10197
*/
10298
fallbackToAppCenter?: boolean;
99+
/**
100+
* Specifies a function to get the release history.
101+
*/
102+
updateChecker: (updateRequest: UpdateCheckRequest) => Promise<ReleaseHistoryInterface>;
103103
}
104104

105105
export interface DownloadProgress {

0 commit comments

Comments
 (0)