Skip to content

Commit be8211a

Browse files
committed
fix bwip error
1 parent b4d1487 commit be8211a

File tree

2 files changed

+24
-14
lines changed

2 files changed

+24
-14
lines changed

src/package.devc.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
44
<asx:values>
55
<DEVC>
6-
<CTEXT>abap2UI5 - custom controls</CTEXT>
6+
<CTEXT>abap2UI5 - js libraries</CTEXT>
77
</DEVC>
88
</asx:values>
99
</asx:abap>

src/z2ui5_cl_cc_bwipjs.clas.abap

+23-13
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ CLASS Z2UI5_CL_CC_BWIPJS IMPLEMENTATION.
9090
|\n| &&
9191
` },` &&
9292
` onAfterRendering() { ` &&
93-
` if(window.bwipjs == undefined) { const loadScript = (FILE_URL, async = true, type = "text/javascript") => {` && |\n| &&
93+
` debugger; if(window.bwipjs == undefined) { const loadScript = (FILE_URL, async = true, type = "text/javascript") => {` && |\n| &&
9494
` return new Promise((resolve, reject) => {` && |\n| &&
9595
` try {` && |\n| &&
9696
` const scriptEle = document.createElement("script");` && |\n| &&
@@ -118,18 +118,28 @@ CLASS Z2UI5_CL_CC_BWIPJS IMPLEMENTATION.
118118
` loadScript("https://cdnjs.cloudflare.com/ajax/libs/bwip-js/4.1.1/bwip-js-min.js")` && |\n| &&
119119
` .then( data => {` && |\n| &&
120120
` this.BusyDialog.close();` && |\n| &&
121-
` let canvas = bwipjs.toCanvas('mycanvas', {` && |\n| &&
122-
` bcid: this.getProperty("bcid"), // Barcode type` && |\n| &&
123-
` text: this.getProperty("text"), // Text to encode` && |\n| &&
124-
` scale: this.getProperty("scale"), // 3x scaling factor` && |\n| &&
125-
` height: this.getProperty("height"), // Bar height, in millimeters` && |\n| &&
126-
` includetext: true, // Show human-readable text` && |\n| &&
127-
` textxalign: 'center', // Always good to set this` && |\n| &&
128-
` })` && |\n| &&
129-
` .catch( err => {` && |\n| &&
130-
` new sap.m.MessageBox.error('Error on load bwip-js library: ' + err);` && |\n| &&
131-
` this.BusyDialog.close();` && |\n| &&
132-
` }); } ) } else {` && |\n| &&
121+
` let canvas = bwipjs.toCanvas('mycanvas', {` && |\n| &&
122+
` bcid: this.getProperty("bcid"),` && |\n| &&
123+
` // Barcode type` && |\n| &&
124+
` text: this.getProperty("text"),` && |\n| &&
125+
` // Text to encode` && |\n| &&
126+
` scale: this.getProperty("scale"),` && |\n| &&
127+
` // 3x scaling factor` && |\n| &&
128+
` height: this.getProperty("height"),` && |\n| &&
129+
` // Bar height, in millimeters` && |\n| &&
130+
` includetext: true,` && |\n| &&
131+
` // Show human-readable text` && |\n| &&
132+
` textxalign: 'center',` && |\n| &&
133+
` // Always good to set this` && |\n| &&
134+
` })` && |\n| &&
135+
* ` .catch(err => {` && |\n| &&
136+
* ` new sap.m.MessageBox.error('Error on load bwip-js library: ' + err);` && |\n| &&
137+
* ` this.BusyDialog.close();` && |\n| &&
138+
* ` }` && |\n| &&
139+
* ` );` && |\n| &&
140+
` }` && |\n| &&
141+
` ) ` && |\n| &&
142+
` } else {` && |\n| &&
133143
` let canvas = bwipjs.toCanvas('mycanvas', {` && |\n| &&
134144
` bcid: this.getProperty("bcid"), // Barcode type` && |\n| &&
135145
` text: this.getProperty("text"), // Text to encode` && |\n| &&

0 commit comments

Comments
 (0)