Fix code standards, remove superglobals (#4523)

* Fix code standards, remove superglobals

* hmm

* global

* fix

Author: danepowell

bin/blt-robo-run.php

@@ -16,7 +16,7 @@
 $timer->start();
 
 // Initialize input and output.
-$input = new ArgvInput($_SERVER['argv']);
+$input = new ArgvInput($argv);
 $output = new ConsoleOutput();
 
 // Write BLT version for debugging.

bin/blt-robo.php

@@ -28,13 +28,13 @@
 function find_repo_root() {
   $possible_repo_roots = [
     getcwd(),
-    realpath(__DIR__ . '/../'),
-    realpath(__DIR__ . '/../../../'),
+    dirname(__DIR__) . '/',
+    dirname(__DIR__, 3) . '/',
   ];
   $blt_files = ['vendor/acquia/blt', 'vendor/autoload.php'];
   // Check for PWD - some local environments will not have this key.
-  if (isset($_SERVER['PWD'])) {
-    array_unshift($possible_repo_roots, $_SERVER['PWD']);
+  if (getenv('PWD')) {
+    array_unshift($possible_repo_roots, getenv('PWD'));
   }
   foreach ($possible_repo_roots as $possible_repo_root) {
     if ($repo_root = find_directory_containing_files($possible_repo_root, $blt_files)) {

composer.json

@@ -42,12 +42,17 @@
         "acquia/blt-behat": "<=1.0.0"
     },
     "require-dev": {
+        "acquia/coding-standards": "^1.0",
+        "dealerdirect/phpcodesniffer-composer-installer": "^0.7.2",
         "squizlabs/php_codesniffer": "^3.6"
     },
     "suggest": {
         "davereid/drush-acquia-hook-invoke": "dev-master"
     },
     "config": {
+        "allow-plugins": {
+            "dealerdirect/phpcodesniffer-composer-installer": true
+        },
         "php": "7",
         "platform": {
             "php": "7.4"
@@ -60,7 +65,7 @@
             "dev-main": "13.x-dev"
         },
         "class": "Acquia\\Blt\\Composer\\Plugin",
-        "phpcodesniffer-search-depth": 4,
+        "phpcodesniffer-search-depth": "4",
         "violinist": {
             "allow_updates_beyond_constraint": 0,
             "bundled_packages": {