Skip to content

doesn't build with stable due to flate2 dependency #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
estokes opened this issue Aug 14, 2019 · 4 comments
Closed

doesn't build with stable due to flate2 dependency #1036

estokes opened this issue Aug 14, 2019 · 4 comments

Comments

@estokes
Copy link

estokes commented Aug 14, 2019 •
edited by JohnTitor
Loading

I just did a cargo update and due to a new release of flate2 actix-web no longer builds. I'm not sure exactly what the issue is with flate2, but the author seems to think it may be because it's being included with default-features = false.

see rust-lang/flate2-rs#205 for more info
@oyvindln
Copy link

oyvindln commented Aug 14, 2019 •
edited
Loading

It seems it's fixable by tacking on libc as a dependency feature in addition to miniz-sys.

@estokes
Copy link
Author

estokes commented Aug 14, 2019

Sure, I was able to work around it, but I thought you guys should know about it.

@JohnTitor JohnTitor mentioned this issue Aug 14, 2019
Closed
@JohnTitor
Copy link
Member

@estokes Could you check if flate2 v1.0.11 fixes this issue?

@JohnTitor
Copy link
Member

The original issue is marked as fixed so I'm going to close this. Feel free to re-open this if you still have a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@estokes @oyvindln @JohnTitor