Skip to content

Homepage doesn't display CircuitPython logo on Firefox #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
todbot opened this issue Apr 11, 2025 · 7 comments · Fixed by #1619
Closed

Homepage doesn't display CircuitPython logo on Firefox #1618

todbot opened this issue Apr 11, 2025 · 7 comments · Fixed by #1619
Assignees

Comments

@todbot
Copy link
Contributor

todbot commented Apr 11, 2025

This is what I see on Firefox. "CircuitPython Logo" text instead of https://circuitpython.org/assets/images/logo-dark.png
Image

@dhalbert
Copy link
Collaborator

dhalbert commented Apr 11, 2025

Can you do a Shift-reload? I see the logo properly on Firefox 137.0 on Linux and also on Firefox 137.0.1 on macOS 15.4.

@todbot
Copy link
Contributor Author

todbot commented Apr 11, 2025

I just installed Firefox on iOS, it’s never loaded the site, and see a similar issue:

Image

@todbot
Copy link
Contributor Author

todbot commented Apr 11, 2025

Similar results in Safari iOS. Safari MacOS looks as expected.

@dhalbert
Copy link
Collaborator

I'm still not seeing this problem, either on iOS (Safari or Firefox), or any other platform. Do you have an iOS phone? Any difference between on WiFi and cellular data?

@jwcooper Any ideas about this?

@Neradoc
Copy link
Contributor

Neradoc commented Apr 11, 2025

Can't repro on Firefox or Safari, does it load on reloading the page ?
Can you have the "network" panel open in firefox when loading the page and not seeing the logo ?
Any errors in the console ?

I can actually see an error in the srcset:

/assets/images/logo-dark.png 1x,
/assets/images/[email protected] 2x,
/assets/images/logo-dark3x.png 3x

The 3rd one should be [email protected]. (The @ is missing)
If I understand the srcset, it picks an image depending on the screen pixel density. On my mac I have a 4k display in "retina" mode at 1080p so it picks the [email protected], which works. But on higher density like a recent iPhone (mine is a XS) it might take the 3x, which is 404: https://circuitpython.org/assets/images/logo-dark3x.png

@dhalbert
Copy link
Collaborator

@todbot should be fixed, if you can test with a shift-reload. Your displays are too good!

Thanks @Neradoc!!

@todbot
Copy link
Contributor Author

todbot commented Apr 11, 2025

Yep fixed! Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants