Adding Prefer enum to tweak behavior. Issue #20

Author: aeshirey

NameParser/NameParser/NameParser.csproj

@@ -2,12 +2,12 @@
   <PropertyGroup>
     <TargetFrameworks>netstandard20;net45</TargetFrameworks>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
-    <AssemblyVersion>1.4.0.0</AssemblyVersion>
-    <FileVersion>1.4.0.0</FileVersion>
+    <AssemblyVersion>1.5.0.0</AssemblyVersion>
+    <FileVersion>1.5.0.0</FileVersion>
     <PackageLicenseUrl>https://licenses.nuget.org/LGPL-2.1-or-later</PackageLicenseUrl>
     <PackageProjectUrl>https://github.com/aeshirey/NameParserSharp</PackageProjectUrl>
     <Description>Parses full name into first name, middle name, last name, nickname, title, and suffix fields</Description>
-    <Version>1.4.0</Version>
+    <Version>1.5.0</Version>
     <PackageId>NameParserSharp</PackageId>
     <Authors>Adam Shirey</Authors>
     <PackageTags>human name parser parsing first middle last nickname</PackageTags>

NameParser/NameParser/Parser.cs

@@ -48,35 +48,17 @@ private set
             }
         }
 
-        public string Title
-        {
-            get { return string.Join(" ", _TitleList); }
-        }
+        public string Title => string.Join(" ", _TitleList);
 
-        public string First
-        {
-            get { return string.Join(" ", _FirstList); }
-        }
+        public string First => string.Join(" ", _FirstList);
 
-        public string Middle
-        {
-            get { return string.Join(" ", _MiddleList); }
-        }
+        public string Middle => string.Join(" ", _MiddleList);
 
-        public string Last
-        {
-            get { return string.Join(" ", _LastList); }
-        }
+        public string Last => string.Join(" ", _LastList);
 
-        public string Suffix
-        {
-            get { return string.Join(" ", _SuffixList); }
-        }
+        public string Suffix => string.Join(" ", _SuffixList);
 
-        public string Nickname
-        {
-            get { return string.Join(" ", _NicknameList); }
-        }
+        public string Nickname => string.Join(" ", _NicknameList);
 
         /// <summary>
         /// If <see cref="ParseMultipleNames"/> is true and the input contains "&" or "and", the additional
@@ -86,17 +68,8 @@ public string Nickname
         /// </summary>
         public HumanName AdditionalName { get; private set; }
 
-        //public string LastBase { get; private set; }
-        public string LastBase
-        {
-            get { return string.Join(" ", _LastBaseList); }
-        }
-
-        //public string LastPrefixes { get; private set; }
-        public string LastPrefixes
-        {
-            get { return string.Join(" ", _LastPrefixList); }
-        }
+        public string LastBase => string.Join(" ", _LastBaseList);
+        public string LastPrefixes => string.Join(" ", _LastPrefixList);
         #endregion
 
         private string _FullName, _OriginalName;
@@ -109,14 +82,17 @@ public string LastPrefixes
         private IList<string> _NicknameList;
         private IList<string> _LastBaseList;
         private IList<string> _LastPrefixList;
+        private Prefer prefs;
 
-        public HumanName(string fullName)
+        public HumanName(string fullName, Prefer prefs = Prefer.Default)
         {
             if (fullName == null)
             {
                 throw new ArgumentNullException("fullName");
             }
 
+            this.prefs = prefs;
+
             FullName = fullName;
         }
 
@@ -300,7 +276,21 @@ private void PostProcessLastname()
                 prefixCount++;
             }
 
-            _LastPrefixList = words.Take(prefixCount).ToList();
+            if (this.prefs.HasFlag(Prefer.FirstOverPrefix)
+                && this._FirstList.Count == 0
+                && prefixCount == 1
+                && words.Count > 1)
+            {
+                _FirstList = words.Take(1).ToList();
+
+                _LastList = words.Skip(1).ToList();
+            }
+            else
+            {
+
+                _LastPrefixList = words.Take(prefixCount).ToList();
+            }
+
             _LastBaseList = words.Skip(prefixCount).ToList();
         }
 

NameParser/NameParser/Prefer.cs

@@ -0,0 +1,21 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace NameParser
+{
+    [Flags]
+    public enum Prefer
+    {
+        Default = 0,
+
+        /// <summary>
+        ///  For Issue #20, when the parser detects a Title and a Last with prefixes (eg, "Mr. Del Richards"), 
+        ///  convert the prefix to a first name.
+        ///  
+        /// This can cause incorrect flipping of prefix to first (eg, "Mr. Van Rossum"), so you should use
+        /// this flag only when you know your data has a first name.
+        /// </summary>
+        FirstOverPrefix = 1,
+    }
+}

NameParser/NameParserTest/NameParserTests.cs

@@ -367,14 +367,22 @@ public void AddToLists()
         /// <summary>
         /// https://github.com/aeshirey/NameParserSharp/issues/20
         /// </summary>
-        //[TestMethod]
+        [TestMethod]
         public void FirstNameIsPrefix()
         {
-            var parsed = new HumanName("Mr. Del Richards");
-            Assert.AreEqual(parsed.Title, "Mr.");
-            Assert.AreEqual(parsed.First, "Del");
-            Assert.AreEqual(parsed.Last, "Richards");
-            Assert.AreEqual(parsed.LastPrefixes, "");
+            // Default behavior
+            var parsed_prefix = new HumanName("Mr. Del Richards");
+            Assert.AreEqual(parsed_prefix.Title, "Mr.");
+            Assert.AreEqual(parsed_prefix.First, "");
+            Assert.AreEqual(parsed_prefix.Last, "Del Richards");
+            Assert.AreEqual(parsed_prefix.LastPrefixes, "Del");
+
+            // A single prefix should be treated as a first name when no first exists
+            var parsed_first = new HumanName("Mr. Del Richards", Prefer.FirstOverPrefix);
+            Assert.AreEqual(parsed_first.Title, "Mr.");
+            Assert.AreEqual(parsed_first.First, "Del");
+            Assert.AreEqual(parsed_first.Last, "Richards");
+            Assert.AreEqual(parsed_first.LastPrefixes, "");
         }
     }
 }