Skip to content

Should aiohttp-cors add a Vary: Origin when emitting a access-control-allow-origin? #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JulienPalard opened this issue Jan 12, 2021 · 1 comment
Open

Should aiohttp-cors add a Vary: Origin when emitting a access-control-allow-origin? #351

JulienPalard opened this issue Jan 12, 2021 · 1 comment

Comments

@JulienPalard
Copy link

When aiohttp-cors writes an header like Access-Control-Allow-Origin, with the Origin request Header, I think it shoul also emit a Vary: Origin (because the response vary according to the Origin). What do you think?
@JulienPalard
Copy link
Author

Also see : https://fetch.spec.whatwg.org/#cors-protocol-and-http-caches

@JulienPalard JulienPalard mentioned this issue Mar 12, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a Vary: Origin header when the response headers vary according to the origin.
1 participant
@JulienPalard