-
Notifications
You must be signed in to change notification settings - Fork 71
Tasks fail in a project using version 4.0.0 of the Android Gradle Plugin #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @jschear. We are facing this same problem after upgrading to AGP 4.0.0 . Were you able to solve this or have a workaround? |
Unfortunately I haven't -- I actually stopped using OkReplay for separate reasons soon after this issue popped up. I think I have a pretty good idea of what needs to be done to fix this issue, though (adopting the |
I think I was wrong about moving to the I see a few ways forward here:
@felipecsl, @rossbacher do either of you have an opinion here? |
Is this issue resolved ? I am encountering similar issue. |
For anyone who might want to use OKReplay in there project with AGP >= 4.0 I followed @jschear steps but instead of fixing the Please note this is not an official solution and something I did to get it working in my project. Steps to run
|
Like @rajab57, I would like to use OkReplay, but it's not working with AGP >= 4.0 :( The @stopdrake's solution seems to work but it would be nice if you can fix it |
The above workaround seems to have stopped working, I now get this error:
I am using the following versions: |
I have also tried the above and get the same error with: Please fix this as it is holding our project up from upgrading the gradle plugin. |
After upgrading to AGP 4.0.0, our
clear<variant>OkReplayTapes
task is failing with aNoClassDefFoundError
. It looks likeConnectedDeviceProvider
was moved to thecom.android.build.gradle.internal.testing
package.I tried upgrading the AGP dependency in OkReplay, but it's going to take a bit of work -- it requires Gradle 6.1.1 at a minimum, but https://github.com/groovy/groovy-android-gradle-plugin isn't compatible with Gradle 6 (and it is no longer maintained), so the tests in the
okreplay-tests
project will probably need to be migrated to Java or Kotlin.I think the best move here is to access the device providers through AGP's
BaseExtension#deviceProviders
API instead of instantiating them directly, which looks like it should work on AGP 3.6.0 and 4.0.0. I'm working on a PR to do that.Stacktrace:
The text was updated successfully, but these errors were encountered: