-
Notifications
You must be signed in to change notification settings - Fork 619
On Windows, modifying scores via zoxide edit
results in a double slashed duplicate of the path
#539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
zoxide edit
results in double slashed duplication of the path
zoxide edit
results in double slashed duplication of the pathzoxide edit
results in a double slashed duplicate of the path
zoxide edit
results in a double slashed duplicate of the pathzoxide edit
results in a double slashed duplicate of the path
Maybe this could be related to #538? |
Confirming this is also happeing to me. Same as #538. Originally did it in Powershell 7/Core then got to replicate it in 5.1. Looks like a Windows bug. With the database serialized, I don't think it's an easy edit via source editor as well. |
Happening to me as well. Windows11, nushell. |
Happening to me as well, both this and #538, on Windows 11 and PowerShell 7. |
+1 |
FYI, Swarnim Arun is drafting #569, which may fix all problems by distinguish |
Any solution or workaround? |
Just tested on my side with zoxide 0.9.7 with both powershell 5.1 and nushell 0.102.0 on Windows 11 and it works: zoxide edit -> increment / decrement some paths -> I see no duplicate being added... |
This seems to have been resolved, I no longer experience this either. (Was previously using Windows Terminal, now wezterm, $v tables below. ❯ echo $PSVersionTable && Write-Host && wezterm -V && zoxide -V # -->
Name Value
---- -----
PSVersion 7.6.0-preview.2
PSEdition Core
GitCommitId 7.6.0-preview.2
OS Microsoft Windows 10.0.26100
Platform Win32NT
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
WSManStackVersion 3.0
wezterm 20240203-110809-5046fc22
zoxide 0.9.7 This can likely be closed unless others are still experiencing this. Edit: |
I also confirm that this issue is resolved. #539 (comment) was posted on 2024-02-16, but https://github.com/ajeetdsouza/zoxide/releases/tag/v0.9.3 published on 2024-02-13 works as expected today. I guess the Windows system somehow changed and fixed the issue silently. |
I haven't experienced this issue for a long time now so it seems to be fixed and this can probably be closed off. Thanks all. |
I'm using zoxide with powershell and wezterm and still having this issue. |
@tommdq which version of zoxide? |
0.9.7 . It keeps adding double \ and creating a new path |
@tommdq very strange, I'm also on that 0.9.7 using Powershell but with Windows Terminal and no longer have the problem. |
As I said before, this issue depends on the context. @tommdq Could you share us with your $PSVersionTable? The following is mine, and it works. > $PSVersionTable
Name Value
---- -----
PSVersion 7.5.0
PSEdition Core
GitCommitId 7.5.0
OS Microsoft Windows 10.0.19045
Platform Win32NT
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
WSManStackVersion 3.0 |
The only difference is my windows version: 20250403-0217-34.1832692.mp4I can delete but the increment and the decrement only keep creating new paths |
In February 2024, my zoxide behaved exactly like yours.
Could you try to
(It works on my machine.) |
Thanks for your help! I tried running PowerShell without a profile, as you suggested, but the result is still the same. Could it be related to the version of pwsh I'm using? (7.5.0) |
Just for reference zoxide is now working for me using Windows Terminal / Powershell / 0.97. Here is my $PSVersion to help in your debugging:
Looks like one difference is that I'm running the Desktop version while you are running the core version. I'm going to update to the core version and see if the issue reappears for me. |
I updated, my $PSVersionTable now looks like:
It's still working as it should, no double slashes or extra entries appearing when modifying score via 'zoxide edit'. Have you tried switching to Windows terminal? Update: I even tried using powershell and wezterm and it's still working fine for me |
Hmm, I also uses pwsh 7.5.0 core, and it works.
Lines 44 to 47 in e1e2f41
Lines 33 to 34 in e1e2f41
Which version do you use? I use the following. > fzf --version
0.61.0 (e15cba0c) |
Right. I updated my fzf (from 0.49 to 0.61) and it working fine now. |
A quick bisect reveals that the first working version of fzf is https://github.com/junegunn/fzf/releases/tag/0.51.0, released on 2024-05-01, and its CHANGELOG said:
The key change was committed by junegunn in junegunn/fzf@8d74446 and junegunn/fzf@194a763, which closed junegunn/fzf#3651 (comment) and junegunn/fzf#2609. Now everything is clear. Time to close this issue! |
That was it. After updating fzf to version 0.61.0 zoxide edit is working as expected. Thanks to everyone !!! Issue solved |
It would be nice to document it somewhere. Several tickets like this were opened. There is this in the readme Install fzf (optional)
[fzf](https://github.com/junegunn/fzf) is a command-line fuzzy finder, used by zoxide for completions / interactive selection. It can be installed from [here](https://github.com/junegunn/fzf#installation).
Note zoxide only supports fzf v0.33.0 and above. Maybe change it to something like: Note zoxide only supports fzf v0.33.0 and above (0.51.0 or above on Windows). |
Before v0.51.0, fzf generates redundant escaping of backslashes for Windows, which breaks `zoxide edit`. https://github.com/junegunn/fzf/releases/tag/0.51.0 Closes ajeetdsouza#539 Co-authored-by: Loïc Riegel <[email protected]>
Before v0.51.0, fzf generates redundant escaping of backslashes for Windows, which breaks `zoxide edit`. https://github.com/junegunn/fzf/releases/tag/0.51.0 Closes ajeetdsouza#539 Co-authored-by: Loïc Riegel <[email protected]>
Before v0.51.0, fzf generates redundant escaping of backslashes for Windows, which breaks `zoxide edit`. https://github.com/junegunn/fzf/releases/tag/0.51.0 Closes ajeetdsouza#539 Co-authored-by: Loïc Riegel <[email protected]>
Runnining
zoxide edit
on Windows and then attempting to increment or decrement a score causes the path to be added to the database again but with double slashes.The text was updated successfully, but these errors were encountered: