Skip to content

Commit 41a64ed

Browse files
mulimoenaldanor
andauthored
Apply suggestions from code review
Co-authored-by: Ivan Smirnov <[email protected]> Signed-off-by: Magnus Ulimoen <[email protected]>
1 parent 307b309 commit 41a64ed

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

hdf5/src/hl/chunks.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ pub struct ChunkInfo {
1010
/// logical positions of the chunk’s first element in each dimension.
1111
pub offset: Vec<u64>,
1212
/// Filter mask that indicates which filters were used with the chunk when written.
13+
///
1314
/// A zero value indicates that all enabled filters are applied on the chunk.
1415
/// A filter is skipped if the bit corresponding to the filter’s position in
1516
/// the pipeline (0 ≤ position < 32) is turned on.
@@ -72,7 +73,7 @@ mod one_thirteen {
7273

7374
/// Borrowed version of [ChunkInfo](crate::dataset::ChunkInfo)
7475
#[derive(Clone, Debug, PartialEq, Eq)]
75-
pub struct ChunkInfoBorrowed<'a> {
76+
pub struct ChunkInfoRef<'a> {
7677
pub offset: &'a [u64],
7778
pub filter_mask: u32,
7879
pub addr: u64,
@@ -97,9 +98,10 @@ mod one_thirteen {
9798
}
9899
}
99100

101+
#[repr(C)]
100102
struct RustCallback<F> {
101-
ndims: usize,
102-
callback: F,
103+
pub ndims: hsize_t,
104+
pub callback: F,
103105
}
104106

105107
extern "C" fn chunks_callback<F>(

0 commit comments

Comments
 (0)