Fix: storage price calculations on small file

Author: 1yam

src/aleph/services/cost.py

@@ -247,7 +247,6 @@ def _get_volumes_costs(
     for volume in volumes:
         if isinstance(volume, SizedVolume):
             storage_mib = Decimal(volume.size_mib)
-
         elif isinstance(volume, RefVolume):
             file = _get_file_from_ref(
                 session=session, ref=volume.ref, use_latest=volume.use_latest
@@ -294,7 +293,7 @@ def _get_execution_volumes_costs(
         volumes.append(
             SizedVolume(
                 CostType.EXECUTION_INSTANCE_VOLUME_ROOTFS,
-                content.rootfs.size_mib,
+                Decimal(content.rootfs.size_mib),
                 content.rootfs.parent.ref,
             )
         )
@@ -339,7 +338,7 @@ def _get_execution_volumes_costs(
                 volumes.append(
                     SizedVolume(
                         CostType.EXECUTION_VOLUME_INMUTABLE,
-                        volume.estimated_size_mib,
+                        Decimal(volume.estimated_size_mib),
                         volume.ref,
                         name,
                     ),
@@ -361,7 +360,7 @@ def _get_execution_volumes_costs(
             volumes.append(
                 SizedVolume(
                     CostType.EXECUTION_VOLUME_PERSISTENT,
-                    volume.size_mib,
+                    Decimal(volume.size_mib),
                     None,
                     name,
                 ),
@@ -498,12 +497,12 @@ def _calculate_storage_costs(
     payment_type = get_payment_type(content)
 
     if isinstance(content, CostEstimationStoreContent) and content.estimated_size_mib:
-        storage_mib = content.estimated_size_mib
+        storage_mib = Decimal(content.estimated_size_mib)
     else:
         file = get_file(session, content.item_hash)
         if not file:
             return []
-        storage_mib = int(file.size / MiB)
+        storage_mib = Decimal(file.size / MiB)
 
     volume = SizedVolume(CostType.STORAGE, storage_mib, item_hash)
 

src/aleph/types/cost.py

@@ -169,7 +169,7 @@ class SizedVolume(VolumeCost):
     def __init__(
         self,
         cost_type: CostType,
-        size_mib: int,
+        size_mib: Decimal,
         ref: Optional[str] = None,
         *args,
     ):

tests/message_processing/test_process_stores.py

@@ -1,5 +1,6 @@
 import datetime as dt
 import json
+from decimal import Decimal
 from typing import Mapping, Optional
 
 import pytest
@@ -12,6 +13,7 @@
 from aleph.handlers.content.store import StoreMessageHandler
 from aleph.handlers.message_handler import MessageHandler
 from aleph.jobs.process_pending_messages import PendingMessageProcessor
+from aleph.services.cost import get_total_and_detailed_costs_from_db
 from aleph.services.storage.engine import StorageEngine
 from aleph.storage import StorageService
 from aleph.toolkit.timestamp import timestamp_to_datetime
@@ -90,6 +92,14 @@ async def test_process_store(
         )
         session.commit()
 
+        cost, _ = get_total_and_detailed_costs_from_db(
+            session=session,
+            content=fixture_store_message.content,
+            item_hash=fixture_store_message.item_hash,
+        )
+
+        assert cost == Decimal("0.000004450480138778")
+
 
 @pytest.mark.asyncio
 async def test_process_store_no_signature(