Skip to content

Commit 87ee95b

Browse files
committed
Explain that we're back on upstream, remove from install_buildtools
1 parent 11ac88b commit 87ee95b

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

daemon/algod/api/README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,11 @@ containing per-round ledger differences that get compacted when actually written
4343

4444
## What codegen tool is used?
4545

46-
We found that [oapi-codegen](https://github.com/deepmap/oapi-codegen) produced the cleanest code, and had an easy to work with codebase. There is an algorand fork of this project which contains a couple modifications that were needed to properly support our needs.
47-
48-
Specifically, `uint64` types aren't strictly supported by OpenAPI. So we added a type-mapping feature to oapi-codegen.
46+
We found that [oapi-codegen](https://github.com/deepmap/oapi-codegen)
47+
produced the cleanest code, and had an easy to work with codebase. We
48+
initially forked it in `algorand/oapi-codegen` but found that features
49+
we added are now available in the upstream repo, so have migrated
50+
back.
4951

5052
## Why do we have algod.oas2.json and algod.oas3.yml?
5153

scripts/buildtools/install_buildtools.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,5 +91,4 @@ install_go_module golang.org/x/tools golang.org/x/tools/cmd/stringer
9191
install_go_module github.com/go-swagger/go-swagger github.com/go-swagger/go-swagger/cmd/swagger
9292
install_go_module github.com/algorand/msgp
9393
install_go_module gotest.tools/gotestsum
94-
install_go_module github.com/oapi-codegen/oapi-codegen github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen
9594
install_go_module github.com/golangci/golangci-lint/cmd/golangci-lint

scripts/buildtools/versions

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
golang.org/x/lint v0.0.0-20241112194109-818c5a804067
22
golang.org/x/tools v0.27.0
33
github.com/algorand/msgp v1.1.60
4-
github.com/oapi-codegen/oapi-codegen v2.4.1
54
github.com/go-swagger/go-swagger v0.31.0
65
gotest.tools/gotestsum v1.12.0
76
github.com/golangci/golangci-lint/cmd/golangci-lint v1.62.0

scripts/check_deps.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ missing_dep() {
3737
GO_DEPS=(
3838
"msgp"
3939
"golangci-lint"
40-
"oapi-codegen"
4140
"swagger"
4241
)
4342

0 commit comments

Comments
 (0)