Skip to content

Commit a1bbe6d

Browse files
committed
Merge branch 'release/2.8.2'
2 parents 57f5a58 + ea39936 commit a1bbe6d

File tree

6 files changed

+23
-42
lines changed

6 files changed

+23
-42
lines changed

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
# 2.8.2
2+
3+
<!-- Release notes generated using configuration in .github/release.yml at release/2.8.2 -->
4+
5+
## What's Changed
6+
### Bugfixes
7+
* API: Revert application boxes pagination by @gmalouf in https://github.com/algorand/java-algorand-sdk/pull/827
8+
9+
10+
**Full Changelog**: https://github.com/algorand/java-algorand-sdk/compare/2.8.1...2.8.2
11+
112
# 2.8.1
213

314
<!-- Release notes generated using configuration in .github/release.yml at release/2.8.1 -->

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Maven:
1919
<dependency>
2020
<groupId>com.algorand</groupId>
2121
<artifactId>algosdk</artifactId>
22-
<version>2.8.1</version>
22+
<version>2.8.2</version>
2323
</dependency>
2424
```
2525

pom.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
<groupId>com.algorand</groupId>
66
<artifactId>algosdk</artifactId>
7-
<version>2.8.1</version>
7+
<version>2.8.2</version>
88
<packaging>jar</packaging>
99

1010
<name>${project.groupId}:${project.artifactId}</name>
@@ -308,7 +308,6 @@
308308
<configuration>
309309
<publishingServerId>central</publishingServerId>
310310
<autoPublish>true</autoPublish>
311-
<waitUntil>published</waitUntil>
312311
</configuration>
313312
</plugin>
314313

src/main/java/com/algorand/algosdk/v2/client/algod/GetApplicationBoxes.java

Lines changed: 5 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@
99

1010

1111
/**
12-
* Given an application ID, return boxes in lexographical order by name. If the
13-
* results must be truncated, a next-token is supplied to continue the request.
12+
* Given an application ID, return all Box names. No particular ordering is
13+
* guaranteed. Request fails when client or server-side configured limits prevent
14+
* returning all Box names.
1415
* /v2/applications/{application-id}/boxes
1516
*/
1617
public class GetApplicationBoxes extends Query {
@@ -26,42 +27,14 @@ public GetApplicationBoxes(Client client, Long applicationId) {
2627
}
2728

2829
/**
29-
* Maximum number of boxes to return. Server may impose a lower limit.
30+
* Max number of box names to return. If max is not set, or max == 0, returns all
31+
* box-names.
3032
*/
3133
public GetApplicationBoxes max(Long max) {
3234
addQuery("max", String.valueOf(max));
3335
return this;
3436
}
3537

36-
/**
37-
* A box name, in the goal app call arg form 'encoding:value'. When provided, the
38-
* returned boxes begin (lexographically) with the supplied name. Callers may
39-
* implement pagination by reinvoking the endpoint with the token from a previous
40-
* call's next-token.
41-
*/
42-
public GetApplicationBoxes next(String next) {
43-
addQuery("next", String.valueOf(next));
44-
return this;
45-
}
46-
47-
/**
48-
* A box name prefix, in the goal app call arg form 'encoding:value'. For ints, use
49-
* the form 'int:1234'. For raw bytes, use the form 'b64:A=='. For printable
50-
* strings, use the form 'str:hello'. For addresses, use the form 'addr:XYZ...'.
51-
*/
52-
public GetApplicationBoxes prefix(String prefix) {
53-
addQuery("prefix", String.valueOf(prefix));
54-
return this;
55-
}
56-
57-
/**
58-
* If true, box values will be returned.
59-
*/
60-
public GetApplicationBoxes values(Boolean values) {
61-
addQuery("values", String.valueOf(values));
62-
return this;
63-
}
64-
6538
/**
6639
* Execute the query.
6740
* @return the query response object.

src/main/java/com/algorand/algosdk/v2/client/common/AlgodClient.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -323,8 +323,9 @@ public GetApplicationByID GetApplicationByID(Long applicationId) {
323323
}
324324

325325
/**
326-
* Given an application ID, return boxes in lexographical order by name. If the
327-
* results must be truncated, a next-token is supplied to continue the request.
326+
* Given an application ID, return all Box names. No particular ordering is
327+
* guaranteed. Request fails when client or server-side configured limits prevent
328+
* returning all Box names.
328329
* /v2/applications/{application-id}/boxes
329330
*/
330331
public GetApplicationBoxes GetApplicationBoxes(Long applicationId) {

src/test/java/com/algorand/algosdk/unit/AlgodPaths.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -100,14 +100,11 @@ public void getBoxByName(Long appID, String encodedBoxName) {
100100
ps.q = algodClient.GetApplicationBoxByName(appID).name(encodedBoxName);
101101
}
102102

103-
@When("we make a GetApplicationBoxes call for applicationID {long} with max {long} prefix {string} next {string} values {string}")
104-
public void getApplicationBoxes(Long appId, Long max, String prefix, String next, String values) {
103+
@When("we make a GetApplicationBoxes call for applicationID {long} with max {long}")
104+
public void getApplicationBoxes(Long appId, Long max) {
105105
GetApplicationBoxes q = algodClient.GetApplicationBoxes(appId);
106106

107107
if (TestingUtils.notEmpty(max)) q.max(max);
108-
if (TestingUtils.notEmpty(prefix)) q.prefix(prefix);
109-
if (TestingUtils.notEmpty(next)) q.next(next);
110-
if (TestingUtils.notEmpty(values)) q.values(values.equals("true"));
111108

112109
ps.q = q;
113110
}

0 commit comments

Comments
 (0)