Skip to content

Commit 55edbf5

Browse files
RandDeebgregkh
authored andcommitted
fs/jfs: Prevent integer overflow in AG size calculation
[ Upstream commit 7fcbf78 ] The JFS filesystem calculates allocation group (AG) size using 1 << l2agsize in dbExtendFS(). When l2agsize exceeds 31 (possible with >2TB aggregates on 32-bit systems), this 32-bit shift operation causes undefined behavior and improper AG sizing. On 32-bit architectures: - Left-shifting 1 by 32+ bits results in 0 due to integer overflow - This creates invalid AG sizes (0 or garbage values) in sbi->bmap->db_agsize - Subsequent block allocations would reference invalid AG structures - Could lead to: - Filesystem corruption during extend operations - Kernel crashes due to invalid memory accesses - Security vulnerabilities via malformed on-disk structures Fix by casting to s64 before shifting: bmp->db_agsize = (s64)1 << l2agsize; This ensures 64-bit arithmetic even on 32-bit architectures. The cast matches the data type of db_agsize (s64) and follows similar patterns in JFS block calculation code. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Rand Deeb <[email protected]> Signed-off-by: Dave Kleikamp <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent 7307c8a commit 55edbf5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/jfs/jfs_dmap.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -3403,7 +3403,7 @@ int dbExtendFS(struct inode *ipbmap, s64 blkno, s64 nblocks)
34033403
oldl2agsize = bmp->db_agl2size;
34043404

34053405
bmp->db_agl2size = l2agsize;
3406-
bmp->db_agsize = 1 << l2agsize;
3406+
bmp->db_agsize = (s64)1 << l2agsize;
34073407

34083408
/* compute new number of AG */
34093409
agno = bmp->db_numag;

0 commit comments

Comments
 (0)