Confluent.Kafka.StrongName project and build (confluentinc#174)

* Added strong name project

* Updates to appveyor to build both signed and unsigned

* Combine commands into single statement

* Removed special StrongName project, instead using build options to sign the assembly

* Signed unit test project that consumes the signed Kafka library

* Added readme file for strong-name unit test project

Author: zikifer

.gitignore

@@ -1,5 +1,6 @@
 project.lock.json
 bin/
+bin-sn/
 obj/
 *.so
 *.dylib

appveyor.yml

@@ -11,16 +11,20 @@ environment:
   PATH: $(PATH);$(PROGRAMFILES)\dotnet\
 
 build_script:
+  - cmd: SET STRONG_NAME_OPTIONS=/p:SignAssembly=true;AssemblyOriginatorKeyFile=Confluent.Kafka.snk;PackageId=Confluent.Kafka.StrongName;AssemblyName=Confluent.Kafka.StrongName;BaseOutputPath=bin-sn\
   - appveyor-retry dotnet restore -v Minimal
+  - appveyor-retry dotnet restore -v Minimal test/Confluent.Kafka.StrongName.UnitTests/Confluent.Kafka.StrongName.UnitTests.csproj
   - dotnet build Confluent.Kafka.sln -c %CONFIGURATION%
-  - cmd: IF "%APPVEYOR_REPO_TAG%" == "true" (dotnet pack src/Confluent.Kafka/Confluent.Kafka.csproj -c %CONFIGURATION%)
-  - cmd: IF NOT "%APPVEYOR_REPO_TAG%" == "true" (dotnet pack src/Confluent.Kafka/Confluent.Kafka.csproj -c %CONFIGURATION% --version-suffix ci-%APPVEYOR_BUILD_NUMBER%)
+  - dotnet build src/Confluent.Kafka/Confluent.Kafka.csproj -c %CONFIGURATION% %STRONG_NAME_OPTIONS%
+  - cmd: IF "%APPVEYOR_REPO_TAG%" == "true" (dotnet pack src/Confluent.Kafka/Confluent.Kafka.csproj -c %CONFIGURATION%  &  dotnet pack src/Confluent.Kafka/Confluent.Kafka.csproj -c %CONFIGURATION% %STRONG_NAME_OPTIONS%)
+  - cmd: IF NOT "%APPVEYOR_REPO_TAG%" == "true" (dotnet pack src/Confluent.Kafka/Confluent.Kafka.csproj -c %CONFIGURATION% --version-suffix ci-%APPVEYOR_BUILD_NUMBER%  &  dotnet pack src/Confluent.Kafka/Confluent.Kafka.csproj -c %CONFIGURATION% %STRONG_NAME_OPTIONS% --version-suffix ci-%APPVEYOR_BUILD_NUMBER%)
 
 test_script:
  - dotnet test -c %CONFIGURATION% --no-build test/Confluent.Kafka.UnitTests/Confluent.Kafka.UnitTests.csproj
+ - dotnet test -c %CONFIGURATION% test/Confluent.Kafka.StrongName.UnitTests/Confluent.Kafka.StrongName.UnitTests.csproj
 
 artifacts:
-  - path: ./src/Confluent.Kafka/bin/Release/*.nupkg
+  - path: ./src/Confluent.Kafka/bin*/Release/*.nupkg
 
 #deploy:
 #  provider: NuGet

src/Confluent.Kafka/Confluent.Kafka.snk

@@ -0,0 +1,37 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFrameworks>netcoreapp1.1;net452</TargetFrameworks>
+    <AssemblyName>Confluent.Kafka.StrongName.UnitTests</AssemblyName>
+    <PackageId>Confluent.Kafka.StrongName.UnitTests</PackageId>
+    <GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
+    <SignAssembly>true</SignAssembly>
+    <AssemblyOriginatorKeyFile>Confluent.Kafka.StrongName.UnitTests.snk</AssemblyOriginatorKeyFile>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <Compile Include="../Confluent.Kafka.UnitTests/**/*.cs" Exclude="../Confluent.Kafka.UnitTests/obj/**/*" />
+  </ItemGroup>
+
+  <ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.1' ">
+    <Reference Include="Confluent.Kafka.StrongName">
+      <HintPath>../../src/Confluent.Kafka/bin-sn/$(Configuration)/netstandard1.3/Confluent.Kafka.StrongName.dll</HintPath>
+    </Reference>
+  </ItemGroup>
+  <ItemGroup Condition=" '$(TargetFramework)' == 'net452' ">
+    <Reference Include="Confluent.Kafka.StrongName">
+      <HintPath>../../src/Confluent.Kafka/bin-sn/$(Configuration)/net45/Confluent.Kafka.StrongName.dll</HintPath>
+    </Reference>
+  </ItemGroup>
+
+  <ItemGroup>
+    <PackageReference Include="librdkafka.redist" Version="0.9.5" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0" />
+    <PackageReference Include="xunit" Version="2.2.0" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.2.0" />
+  </ItemGroup>
+
+</Project>

test/Confluent.Kafka.StrongName.UnitTests/Confluent.Kafka.StrongName.UnitTests.csproj

@@ -0,0 +1,6 @@
+Strongly Named Unit Tests
+=========================
+
+This project, which is not included in the main solution, is designed for the sole purpose of verifying that the signed version of `Confluent.Kafka` (`Confluent.Kafka.StrongName`) has been built and signed correctly.  This project is built and run by the Travis build script.
+
+When the build script begins, it performs a `dotnet build` on the main solution file.  After this has completed, it rebuilds the main `Confluent.Kafka` library, this time including signing information.  The output of this build step is the `Confluent.Kafka.StrongName` assembly.  Once `Confluent.Kafka.StrongName` has been built, this unit test assmbly, `Confluent.Kafka.StrongName.UnitTests`, is built and run against `Confluent.Kafka.StrongName`.  The `Confluent.Kafka.StrongName.UnitTests` assmbly itself is signed, and as such requires all dependencies to also be signed.  Should `Confluent.Kafka.StrongName` not actually be signed this build and test will fail.