Skip to content

Regex for coloring lines misses the M flag #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
angely-dev opened this issue Mar 8, 2023 · 0 comments
Closed

Regex for coloring lines misses the M flag #3

angely-dev opened this issue Mar 8, 2023 · 0 comments
Assignees
@angely-dev
Labels
bug Something isn't working
Milestone
1.2.0

Comments

@angely-dev
Copy link
Owner

The current regex for coloring lines misses the M multi-line flag. As a consequence, some parts of the lines are wrongly colored if they contain a +:

image

At first glance, the fix only requires to adapt the regex in incremental_diff.py#L37.
@angely-dev angely-dev added the bug Something isn't working label Mar 8, 2023
@angely-dev angely-dev added this to the 1.2.0 milestone Mar 8, 2023
@angely-dev angely-dev self-assigned this Mar 8, 2023
angely-dev added a commit that referenced this issue Mar 9, 2023
@angely-dev
#3 Add M regex flag for colored diff
5fa21af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angely-dev angely-dev

Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
1 participant
@angely-dev