Skip to content

Commit be14609

Browse files
committed
🎨🧪 Include linters into the main CI workflow
This approach allows depending on linting outcome in the branch protection. It also lets us keep the workflow bits modular.
1 parent dcc1415 commit be14609

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

.github/workflows/build-test-n-publish.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,9 @@ env:
8383
8484
8585
jobs:
86+
lint:
87+
uses: ./.github/workflows/reusable-linters.yml
88+
8689
pre-setup:
8790
name: ⚙️ Pre-set global build settings
8891
runs-on: ubuntu-latest
@@ -2104,6 +2107,7 @@ jobs:
21042107
needs:
21052108
- build-rpms
21062109
- dist-meta
2110+
- lint
21072111
- test-linux
21082112
- test-macos
21092113

.github/workflows/tox-linters.yml renamed to .github/workflows/reusable-linters.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,7 @@ on: # yamllint disable-line rule:truthy
88
# NOTE: bot-managed branches don't need to be linted on
99
# NOTE: push: they always have PR builds
1010
- dependabot/**
11-
pull_request:
12-
schedule:
13-
- cron: 1 0 * * * # Run daily at 0:01 UTC
14-
# Run every Friday at 18:02 UTC
15-
# https://crontab.guru/#2_18_*_*_5
16-
# - cron: 2 18 * * 5
11+
workflow_call:
1712

1813
jobs:
1914
linters:

README.rst

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,6 @@
1111
:alt: GitHub Workflow Status (🏗 📦 & test & publish/devel)
1212
:target: https://github.com/ansible/pylibssh/actions?query=workflow%3A%22%F0%9F%8F%97+%F0%9F%93%A6+%26+test+%26+publish%22+branch%3Adevel
1313

14-
.. image:: https://img.shields.io/github/workflow/status/ansible/pylibssh/%F0%9F%9A%A8/devel?label=GitHub%20Actions%20%5Bquality%5D&logo=github
15-
:target: https://github.com/ansible/pylibssh/actions?query=workflow%3A%F0%9F%9A%A8+branch%3Adevel
16-
:alt: GitHub Workflow Status (🚨/devel)
17-
1814
.. image:: https://img.shields.io/codecov/c/gh/ansible/pylibssh/devel?logo=codecov&logoColor=white
1915
:target: https://codecov.io/gh/ansible/pylibssh
2016
:alt: devel branch coverage via Codecov

0 commit comments

Comments
 (0)