@@ -16,7 +16,7 @@ pub fn write_batch_fast(batch: &RecordBatch, output: &mut Vec<u8>) -> Result<(),
16
16
let field_name = field. name ( ) ;
17
17
let field_name_len = field_name. len ( ) ;
18
18
output. write_all ( & field_name_len. to_le_bytes ( ) [ ..] ) ?;
19
- output. write ( field_name. as_str ( ) . as_bytes ( ) ) ?;
19
+ output. write_all ( field_name. as_str ( ) . as_bytes ( ) ) ?;
20
20
21
21
// TODO write field type using FFI_ArrowSchema encoding, assume string for now
22
22
}
@@ -38,7 +38,7 @@ pub fn write_batch_fast(batch: &RecordBatch, output: &mut Vec<u8>) -> Result<(),
38
38
39
39
// write data buffer
40
40
// println!("writing data buffer with {buffer_len} bytes");
41
- output. write ( buffer) ?;
41
+ output. write_all ( buffer) ?;
42
42
43
43
// write offset buffer length
44
44
let offsets = string_array. offsets ( ) ;
@@ -50,7 +50,7 @@ pub fn write_batch_fast(batch: &RecordBatch, output: &mut Vec<u8>) -> Result<(),
50
50
// write offset buffer
51
51
let offset_buffer = scalar_buffer. inner ( ) . as_slice ( ) ;
52
52
// println!("writing offset buffer with {offset_buffer_len} bytes");
53
- output. write ( offset_buffer) ?;
53
+ output. write_all ( offset_buffer) ?;
54
54
}
55
55
_ => todo ! ( ) ,
56
56
}
@@ -203,7 +203,11 @@ mod test {
203
203
for i in 0 ..8192 {
204
204
b. append_value ( format ! ( "{i}" ) ) ;
205
205
}
206
- let array = Arc :: new ( b. finish ( ) ) ;
207
- RecordBatch :: try_new ( schema. clone ( ) , vec ! [ array. clone( ) , array. clone( ) , array] ) . unwrap ( )
206
+ let array: ArrayRef = Arc :: new ( b. finish ( ) ) ;
207
+ RecordBatch :: try_new (
208
+ schema. clone ( ) ,
209
+ vec ! [ Arc :: clone( & array) , Arc :: clone( & array) , array] ,
210
+ )
211
+ . unwrap ( )
208
212
}
209
213
}
0 commit comments