review comments

Author: parthchandra

common/src/main/scala/org/apache/spark/sql/comet/parquet/CometParquetReadSupport.scala

@@ -363,7 +363,7 @@ object CometParquetReadSupport {
   /**
    * Whether the parquet schema contains any field IDs.
    */
-  def containsFieldIds(schema: Type): Boolean = schema match {
+  private def containsFieldIds(schema: Type): Boolean = schema match {
     case p: PrimitiveType => p.getId != null
     // We don't require all fields to have IDs, so we use `exists` here.
     case g: GroupType => g.getId != null || g.getFields.asScala.exists(containsFieldIds)

spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala

@@ -1234,8 +1234,7 @@ abstract class ParquetReadSuite extends CometTestBase {
             withParquetDataFrame(data, schema = Some(readSchema)) { df =>
               // TODO: validate with Spark 3.x and 'usingDataFusionParquetExec=true'
               if (enableSchemaEvolution || CometConf.COMET_NATIVE_SCAN_IMPL
-                  .get(conf)
-                  .equals(CometConf.SCAN_NATIVE_DATAFUSION)) {
+                  .get(conf) == CometConf.SCAN_NATIVE_DATAFUSION) {
                 checkAnswer(df, data.map(Row.fromTuple))
               } else {
                 assertThrows[SparkException](df.collect())