Skip to content

Commit b3ee833

Browse files
authored
Minor: remove unnecessary dependencies in datafusion-sqllogictest (#14578)
* Minor: remove unnecessary dependencies in `datafusion-sqllogictest` * fix
1 parent 32c760b commit b3ee833

File tree

9 files changed

+20
-27
lines changed

9 files changed

+20
-27
lines changed

Cargo.lock

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

datafusion/sqllogictest/Cargo.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@ bytes = { workspace = true, optional = true }
4242
chrono = { workspace = true, optional = true }
4343
clap = { version = "4.5.16", features = ["derive", "env"] }
4444
datafusion = { workspace = true, default-features = true, features = ["avro"] }
45-
datafusion-catalog = { workspace = true, default-features = true }
46-
datafusion-common = { workspace = true, default-features = true }
47-
datafusion-common-runtime = { workspace = true, default-features = true }
4845
futures = { workspace = true }
4946
half = { workspace = true, default-features = true }
5047
indicatif = "0.17"

datafusion/sqllogictest/bin/postgres_container.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
// under the License.
1717

1818
use crate::Options;
19-
use datafusion_common::Result;
19+
use datafusion::common::Result;
2020
use log::info;
2121
use std::env::set_var;
2222
use std::future::Future;

datafusion/sqllogictest/bin/sqllogictests.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,9 @@
1616
// under the License.
1717

1818
use clap::Parser;
19-
use datafusion_common::instant::Instant;
20-
use datafusion_common::utils::get_available_parallelism;
21-
use datafusion_common::{exec_err, DataFusionError, Result};
22-
use datafusion_common_runtime::SpawnedTask;
19+
use datafusion::common::instant::Instant;
20+
use datafusion::common::utils::get_available_parallelism;
21+
use datafusion::common::{exec_err, DataFusionError, Result};
2322
use datafusion_sqllogictest::{
2423
df_value_validator, read_dir_recursive, setup_scratch_dir, value_normalizer,
2524
DataFusion, TestContext,
@@ -40,6 +39,7 @@ use sqllogictest::{
4039
use crate::postgres_container::{
4140
initialize_postgres_container, terminate_postgres_container,
4241
};
42+
use datafusion::common::runtime::SpawnedTask;
4343
use std::ffi::OsStr;
4444
use std::path::{Path, PathBuf};
4545

@@ -330,7 +330,7 @@ async fn run_test_file_with_postgres(
330330
_mp: MultiProgress,
331331
_mp_style: ProgressStyle,
332332
) -> Result<()> {
333-
use datafusion_common::plan_err;
333+
use datafusion::common::plan_err;
334334
plan_err!("Can not run with postgres as postgres feature is not enabled")
335335
}
336336

@@ -446,7 +446,7 @@ async fn run_complete_file_with_postgres(
446446
_mp: MultiProgress,
447447
_mp_style: ProgressStyle,
448448
) -> Result<()> {
449-
use datafusion_common::plan_err;
449+
use datafusion::common::plan_err;
450450
plan_err!("Can not run with postgres as postgres feature is not enabled")
451451
}
452452

datafusion/sqllogictest/src/engines/datafusion_engine/error.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
// under the License.
1717

1818
use arrow::error::ArrowError;
19-
use datafusion_common::DataFusionError;
19+
use datafusion::error::DataFusionError;
2020
use sqllogictest::TestError;
2121
use sqlparser::parser::ParserError;
2222
use thiserror::Error;

datafusion/sqllogictest/src/engines/datafusion_engine/normalize.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,18 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18+
use super::super::conversion::*;
19+
use super::error::{DFSqlLogicTestError, Result};
1820
use crate::engines::output::DFColumnType;
1921
use arrow::array::{Array, AsArray};
2022
use arrow::datatypes::Fields;
2123
use arrow::util::display::ArrayFormatter;
2224
use arrow::{array, array::ArrayRef, datatypes::DataType, record_batch::RecordBatch};
23-
use datafusion_common::format::DEFAULT_CLI_FORMAT_OPTIONS;
24-
use datafusion_common::DataFusionError;
25+
use datafusion::common::format::DEFAULT_CLI_FORMAT_OPTIONS;
26+
use datafusion::common::DataFusionError;
2527
use std::path::PathBuf;
2628
use std::sync::LazyLock;
2729

28-
use super::super::conversion::*;
29-
use super::error::{DFSqlLogicTestError, Result};
30-
3130
/// Converts `batches` to a result as expected by sqllogictest.
3231
pub fn convert_batches(batches: Vec<RecordBatch>) -> Result<Vec<Vec<String>>> {
3332
if batches.is_empty() {

datafusion/sqllogictest/src/engines/postgres_engine/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717

1818
use async_trait::async_trait;
1919
use bytes::Bytes;
20-
use datafusion_common_runtime::SpawnedTask;
20+
use datafusion::common::runtime::SpawnedTask;
2121
use futures::{SinkExt, StreamExt};
2222
use log::{debug, info};
2323
use sqllogictest::DBOutput;

datafusion/sqllogictest/src/test_context.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,20 @@ use arrow::array::{
2727
};
2828
use arrow::datatypes::{DataType, Field, Schema, SchemaRef, TimeUnit};
2929
use arrow::record_batch::RecordBatch;
30+
use datafusion::catalog::{
31+
CatalogProvider, MemoryCatalogProvider, MemorySchemaProvider, Session,
32+
};
33+
use datafusion::common::DataFusionError;
3034
use datafusion::logical_expr::{create_udf, ColumnarValue, Expr, ScalarUDF, Volatility};
3135
use datafusion::physical_plan::ExecutionPlan;
32-
use datafusion::prelude::SessionConfig;
36+
use datafusion::prelude::*;
3337
use datafusion::{
3438
datasource::{MemTable, TableProvider, TableType},
3539
prelude::{CsvReadOptions, SessionContext},
3640
};
37-
use datafusion_catalog::CatalogProvider;
38-
use datafusion_catalog::{memory::MemoryCatalogProvider, memory::MemorySchemaProvider};
39-
use datafusion_common::cast::as_float64_array;
40-
use datafusion_common::DataFusionError;
4141

4242
use async_trait::async_trait;
43-
use datafusion::catalog::Session;
43+
use datafusion::common::cast::as_float64_array;
4444
use log::info;
4545
use tempfile::TempDir;
4646

datafusion/sqllogictest/src/util.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
// specific language governing permissions and limitations
1616
// under the License.
1717

18-
use datafusion_common::{exec_datafusion_err, Result};
18+
use datafusion::common::{exec_datafusion_err, Result};
1919
use itertools::Itertools;
2020
use log::Level::Warn;
2121
use log::{info, log_enabled, warn};

0 commit comments

Comments
 (0)